Fix crash QsciAPIs is destroyed while worker running

qgis · Jul 6, 2021 · 9adbdfa · 9adbdfa
1 parent e1a8ef5
commit 9adbdfa
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 2 deletions.
diff --git a/python/gui/auto_generated/codeeditors/qgscodeeditorsql.sip.in b/python/gui/auto_generated/codeeditors/qgscodeeditorsql.sip.in
@@ -31,6 +31,9 @@ code autocompletion.
 Constructor for QgsCodeEditorSQL
 %End
 
+
+    virtual ~QgsCodeEditorSQL();
+
     void setFields( const QgsFields &fields );
 %Docstring
 Set field names to be added to the lexer API.

diff --git a/src/gui/codeeditors/qgscodeeditorsql.cpp b/src/gui/codeeditors/qgscodeeditorsql.cpp
@@ -34,6 +34,14 @@ QgsCodeEditorSQL::QgsCodeEditorSQL( QWidget *parent )
   QgsCodeEditorSQL::initializeLexer(); // avoid cppcheck warning by explicitly specifying namespace
 }
 
+QgsCodeEditorSQL::~QgsCodeEditorSQL()
+{
+  if ( mApis )
+  {
+    mApis->cancelPreparation( );
+  }
+}
+
 void QgsCodeEditorSQL::initializeLexer()
 {
   QFont font = lexerFont();

diff --git a/src/gui/codeeditors/qgscodeeditorsql.h b/src/gui/codeeditors/qgscodeeditorsql.h
@@ -39,6 +39,9 @@ class GUI_EXPORT QgsCodeEditorSQL : public QgsCodeEditor
     //! Constructor for QgsCodeEditorSQL
     QgsCodeEditorSQL( QWidget *parent SIP_TRANSFERTHIS = nullptr );
 
+
+    virtual ~QgsCodeEditorSQL();
+
     /**
      * Set field names to be added to the lexer API.
      *

diff --git a/tests/src/gui/testqgsqueryresultwidget.cpp b/tests/src/gui/testqgsqueryresultwidget.cpp
@@ -105,8 +105,6 @@ void TestQgsQueryResultWidget::testWidgetCrash()
   QTimer::singleShot( 1, d.get(), [ & ] { exited = true; } );
   while ( ! exited )
     QgsApplication::processEvents();
-  // This prevents a crash in Qsci internal thread
-  std::this_thread::sleep_for( std::chrono::seconds( 1 ) );
 }