QgsSettings: removed lower(), now it's case sensistive

elpaso · elpaso · commit 99f859e2ac2e · 2017-03-06T10:51:54.000+01:00
diff --git a/python/core/qgssettings.sip b/python/core/qgssettings.sip
@@ -21,8 +21,6 @@
  * - the second one (Global Settings) is meant to provide read-only
  *   pre-configuration and defaults to the first one.
  *
- * Unlike the original QSettings, the keys of QgsSettings are case insensitive.
- *
  * For a given settings key, the function call to value(key, default) will return
  * the first existing setting in the order specified below:
  *  - User Settings
@@ -155,7 +153,6 @@ typedef PyObject *(*pyqt5_from_qvariant_by_type)(QVariant &value, PyObject *type
   void setArrayIndex( int i );
   //! Sets the value of setting key to value. If the key already exists, the previous value is overwritten.
   //! An optional Section argument can be used to set a value to a specific Section.
-  //! @note keys are case insensitive
   void setValue(const QString &key, const QVariant &value, const QgsSettings::Section section = QgsSettings::Section::NoSection );
   /** Returns the value for setting key. If the setting doesn't exist, it will be
    * searched in the Global Settings and if not found, returns defaultValue.
diff --git a/src/core/qgssettings.cpp b/src/core/qgssettings.cpp
@@ -256,7 +256,7 @@ void QgsSettings::setValue( const QString &key, const QVariant &value, const Qgs
 // To lower case and clean the path
 QString QgsSettings::sanitizeKey( QString key ) const
 {
-  return QDir::cleanPath( key.toLower() );
+  return QDir::cleanPath( key );
 }
 
 void QgsSettings::clear()
diff --git a/src/core/qgssettings.h b/src/core/qgssettings.h
@@ -28,8 +28,6 @@
  * - the second one (Global Settings) is meant to provide read-only
  *   pre-configuration and defaults to the first one.
  *
- * Unlike the original QSettings, the keys of QgsSettings are case insensitive.
- *
  * For a given settings key, the function call to value(key, default) will return
  * the first existing setting in the order specified below:
  *  - User Settings
@@ -158,7 +156,6 @@ class CORE_EXPORT QgsSettings : public QObject
     void setArrayIndex( int i );
     //! Sets the value of setting key to value. If the key already exists, the previous value is overwritten.
     //! An optional Section argument can be used to set a value to a specific Section.
-    //! @note keys are case insensitive
     void setValue( const QString &key, const QVariant &value, const Section section = Section::NoSection );
 
     /** Returns the value for setting key. If the setting doesn't exist, it will be
diff --git a/tests/src/python/test_qgssettings.py b/tests/src/python/test_qgssettings.py
@@ -219,9 +219,9 @@ def test_contains(self):
 
     def test_remove(self):
         self.settings.setValue('testQgisSettings/temp', True)
-        self.assertEqual(self.settings.value('testqgissettings/temp'), True)
+        self.assertEqual(self.settings.value('testQgisSettings/temp'), True)
         self.settings.remove('testQgisSettings/temp')
-        self.assertEqual(self.settings.value('testqgissettings/temp'), None)
+        self.assertEqual(self.settings.value('testqQgisSettings/temp'), None)
 
 
 if __name__ == '__main__':

Original file line number	Diff line number	Diff line change
`@@ -256,7 +256,7 @@ void QgsSettings::setValue( const QString &key, const QVariant &value, const Qgs`
`256`	`256`	`// To lower case and clean the path`
`257`	`257`	`QString QgsSettings::sanitizeKey( QString key ) const`
`258`	`258`	`{`
`259`		`- return QDir::cleanPath( key.toLower() );`
	`259`	`+ return QDir::cleanPath( key );`
`260`	`260`	`}`
`261`	`261`
`262`	`262`	`void QgsSettings::clear()`