Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Make attribute selection table in vector save as dialog taller
  • Loading branch information
nyalldawson committed Apr 3, 2016
1 parent cbad546 commit 98d4734
Showing 1 changed file with 15 additions and 7 deletions.
22 changes: 15 additions & 7 deletions src/ui/qgsvectorlayersaveasdialogbase.ui
Expand Up @@ -71,7 +71,7 @@
</widget>
</item>
<item row="2" column="1" colspan="2">
<widget class="QgsProjectionSelectionWidget" name="mCrsSelector">
<widget class="QgsProjectionSelectionWidget" name="mCrsSelector" native="true">
<property name="focusPolicy">
<enum>Qt::StrongFocus</enum>
</property>
Expand All @@ -89,9 +89,9 @@
<property name="geometry">
<rect>
<x>0</x>
<y>0</y>
<width>553</width>
<height>548</height>
<y>-427</y>
<width>555</width>
<height>899</height>
</rect>
</property>
<layout class="QVBoxLayout" name="verticalLayout">
Expand Down Expand Up @@ -130,12 +130,18 @@
<property name="checked">
<bool>false</bool>
</property>
<property name="collapsed">
<property name="collapsed" stdset="0">
<bool>true</bool>
</property>
<layout class="QVBoxLayout" name="verticalLayout_4">
<item>
<widget class="QTableWidget" name="mAttributeTable">
<property name="minimumSize">
<size>
<width>0</width>
<height>200</height>
</size>
</property>
<property name="rowCount">
<number>1</number>
</property>
Expand Down Expand Up @@ -288,7 +294,7 @@
<property name="title">
<string>Custom Options</string>
</property>
<property name="collapsed">
<property name="collapsed" stdset="0">
<bool>true</bool>
</property>
<layout class="QGridLayout" name="gridLayout_3">
Expand Down Expand Up @@ -426,6 +432,9 @@
<tabstop>mEncodingComboBox</tabstop>
<tabstop>mSelectedOnly</tabstop>
<tabstop>mAttributesSelection</tabstop>
<tabstop>mAttributeTable</tabstop>
<tabstop>mSelectAllAttributes</tabstop>
<tabstop>mDeselectAllAttributes</tabstop>
<tabstop>mAddToCanvas</tabstop>
<tabstop>mSymbologyExportComboBox</tabstop>
<tabstop>mScaleSpinBox</tabstop>
Expand All @@ -434,7 +443,6 @@
<tabstop>mIncludeZCheckBox</tabstop>
<tabstop>mOgrDatasourceOptions</tabstop>
<tabstop>mOgrLayerOptions</tabstop>
<tabstop>buttonBox</tabstop>
</tabstops>
<resources/>
<connections>
Expand Down

2 comments on commit 98d4734

@nirvn
Copy link
Contributor

@nirvn nirvn commented on 98d4734 Apr 4, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jef-n , @nyalldawson , I was thinking last night that it'd be nice to allow - through this newly-added UI - to rename fields in the save as... dialog.

@nyalldawson
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nirvn - go for it ;) based on your recent contributions I'd say you've got the skills! It could be implemented by adding a new stringlist parameter to QgsVectorFileWriter::writeAsVectorFormat for the new field names. Then around qgsvectorfilewriter.cpp:2090 you'd need to rename the field. Add a test in test_qgsvectorfilewriter.py to verify that the changes are working OK, then it's just the GUI changes to do.

Please sign in to comment.