Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
fix findSIP when SIP >= 4.19.10 (#7329)
  • Loading branch information
3nids committed Jun 28, 2018
1 parent 4d0d19b commit 98bce5b
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion cmake/FindSIP.py
Expand Up @@ -39,4 +39,7 @@
print("sip_bin:%s" % sipcfg.sip_bin)
print("default_sip_dir:%s" % sipcfg.default_sip_dir)
print("sip_inc_dir:%s" % sipcfg.sip_inc_dir)
print("sip_mod_dir:%s" % sipcfg.sip_mod_dir)
if sipcfg.sip_version >= int('04130a', 16):
print("sip_mod_dir:%s" % sipcfg.sip_mod_dir)
else:
print("sip_module_dir:%s" % sipcfg.sip_module_dir)

1 comment on commit 98bce5b

@wonder-sk
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @3nids now I am getting an error when running cmake:

-- Found Python executable: /usr/bin/python3
-- Found Python version: 3.6.3
-- Found Python library: /usr/lib/x86_64-linux-gnu/libpython3.6m.so
-- Found Python site-packages: /usr/lib/python3/dist-packages
-- Found PyQt5 version: 5.7
Traceback (most recent call last):
  File "/home/martin/qgis/git-master/cmake/FindSIP.py", line 45, in <module>
    print("sip_module_dir:%s" % sipcfg.sip_module_dir)
  File "/usr/lib/python3/dist-packages/sipconfig_nd6.py", line 191, in __getattr__
    raise AttributeError("\"%s\" is not a valid configuration value or user option" % name)
AttributeError: "sip_module_dir" is not a valid configuration value or user option
-- Found SIP version: 4.18.1

Please sign in to comment.