Simple line can cause tile artifacts if it's a dashed line

qgis · Feb 12, 2021 · 980d969 · 980d969
1 parent 080ec98
commit 980d969
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 1 deletion.
diff --git a/python/core/auto_generated/symbology/qgslinesymbollayer.sip.in b/python/core/auto_generated/symbology/qgslinesymbollayer.sip.in
@@ -84,6 +84,8 @@ Creates a new QgsSimpleLineSymbolLayer from an SLD XML DOM ``element``.
 
     virtual QColor dxfColor( QgsSymbolRenderContext &context ) const;
 
+    virtual bool canCauseArtifactsBetweenAdjacentTiles() const;
+
 
     Qt::PenStyle penStyle() const;
 %Docstring

diff --git a/src/core/project/qgsprojectfiletransform.cpp b/src/core/project/qgsprojectfiletransform.cpp
@@ -635,7 +635,7 @@ void transform1800to1900( QgsProjectFileTransform *pft )
     }
   }
 
-  QgsDebugMsg( pft->dom().toString() );
+  QgsDebugMsgLevel( pft->dom().toString(), 2 );
 }
 
 void transform2200to2300( QgsProjectFileTransform *pft )

diff --git a/src/core/symbology/qgslinesymbollayer.cpp b/src/core/symbology/qgslinesymbollayer.cpp
@@ -999,6 +999,11 @@ QColor QgsSimpleLineSymbolLayer::dxfColor( QgsSymbolRenderContext &context ) con
   return mColor;
 }
 
+bool QgsSimpleLineSymbolLayer::canCauseArtifactsBetweenAdjacentTiles() const
+{
+  return mPenStyle != Qt::SolidLine || mUseCustomDashPattern;
+}
+
 bool QgsSimpleLineSymbolLayer::alignDashPattern() const
 {
   return mAlignDashPattern;

diff --git a/src/core/symbology/qgslinesymbollayer.h b/src/core/symbology/qgslinesymbollayer.h
@@ -84,6 +84,7 @@ class CORE_EXPORT QgsSimpleLineSymbolLayer : public QgsLineSymbolLayer
     double dxfWidth( const QgsDxfExport &e, QgsSymbolRenderContext &context ) const override;
     double dxfOffset( const QgsDxfExport &e, QgsSymbolRenderContext &context ) const override;
     QColor dxfColor( QgsSymbolRenderContext &context ) const override;
+    bool canCauseArtifactsBetweenAdjacentTiles() const override;
 
     /**
      * Returns the pen style used to render the line (e.g. solid, dashed, etc).