Simplify other_fields detection

qgis · Feb 20, 2021 · 97880d7 · 97880d7
1 parent ef6799f
commit 97880d7
Showing 1 changed file with 5 additions and 11 deletions.
diff --git a/python/plugins/processing/algs/gdal/OneSideBuffer.py b/python/plugins/processing/algs/gdal/OneSideBuffer.py
@@ -125,17 +125,6 @@ def getConsoleCommands(self, parameters, context, feedback, executing=True):
 
         output, outputFormat = GdalUtils.ogrConnectionStringAndFormat(outFile, context)
 
-        other_fields = [
-            '"{}"'.format(f.name())
-            for f in fields
-            if f.name() != geometry
-        ]
-
-        if other_fields:
-            other_fields = ',*'
-        else:
-            other_fields = ''
-
         arguments = [
             output,
             ogrLayer,
@@ -144,6 +133,11 @@ def getConsoleCommands(self, parameters, context, feedback, executing=True):
             '-sql'
         ]
 
+        other_fields = ',*' if any(
+            f for f in fields
+            if f.name() != geometry
+        ) else ''
+
         if dissolve or fieldName:
             sql = 'SELECT ST_Union(ST_SingleSidedBuffer({}, {}, {})) AS {}{} FROM "{}"'.format(geometry, distance, side, geometry, other_fields, layerName)
         else: