Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
remove extra SIP_TRANSFERTHIS in cpp files
- Loading branch information
Showing
2 changed files
with
2 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
96151e7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good cleanup thanks.
While we're at it, those superfluous SIP_TRANSFERTHIS were an attempt to fix build warnings when this tag is used in headers coupled with the use of \param documentation tag. Any idea what happens here? The only way to resolve it is to remove all param tags for a given function.
96151e7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, doxygen config file had no
INCLUDE_PATH
defined, hence it did not findqgis.h
and its SIP macro definitions. This has been fixed in 448d2fd, you can safely use\param
in combination ofSIP_TRANSFERTHIS
96151e7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice