Skip to content

Commit

Permalink
remove extra SIP_TRANSFERTHIS in cpp files
Browse files Browse the repository at this point in the history
  • Loading branch information
3nids committed Apr 25, 2017
1 parent 4b67b27 commit 96151e7
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/gui/qgscolorbutton.cpp
Expand Up @@ -38,7 +38,7 @@
#include <QGridLayout>
#include <QPushButton>

QgsColorButton::QgsColorButton( QWidget *parent SIP_TRANSFERTHIS, const QString &cdt, QgsColorSchemeRegistry *registry )
QgsColorButton::QgsColorButton( QWidget *parent, const QString &cdt, QgsColorSchemeRegistry *registry )
: QToolButton( parent )
, mBehavior( QgsColorButton::ShowDialog )
, mColorDialogTitle( cdt.isEmpty() ? tr( "Select Color" ) : cdt )
Expand Down
2 changes: 1 addition & 1 deletion src/gui/qgscolorrampbutton.cpp
Expand Up @@ -36,7 +36,7 @@
#include <QPushButton>
#include <QWidget>

QgsColorRampButton::QgsColorRampButton( QWidget *parent SIP_TRANSFERTHIS, const QString &dialogTitle )
QgsColorRampButton::QgsColorRampButton( QWidget *parent, const QString &dialogTitle )
: QToolButton( parent )
, mColorRampDialogTitle( dialogTitle.isEmpty() ? tr( "Select Color Ramp" ) : dialogTitle )
, mShowGradientOnly( false )
Expand Down

3 comments on commit 96151e7

@nirvn
Copy link
Contributor

@nirvn nirvn commented on 96151e7 Apr 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good cleanup thanks.

While we're at it, those superfluous SIP_TRANSFERTHIS were an attempt to fix build warnings when this tag is used in headers coupled with the use of \param documentation tag. Any idea what happens here? The only way to resolve it is to remove all param tags for a given function.

@3nids
Copy link
Member Author

@3nids 3nids commented on 96151e7 Apr 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, doxygen config file had no INCLUDE_PATH defined, hence it did not find qgis.h and its SIP macro definitions. This has been fixed in 448d2fd, you can safely use \param in combination of SIP_TRANSFERTHIS

@nirvn
Copy link
Contributor

@nirvn nirvn commented on 96151e7 Apr 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Please sign in to comment.