Skip to content

Commit

Permalink
Fix build
Browse files Browse the repository at this point in the history
  • Loading branch information
nyalldawson committed May 20, 2021
1 parent e6bc53b commit 9589813
Show file tree
Hide file tree
Showing 3 changed files with 27 additions and 26 deletions.
26 changes: 13 additions & 13 deletions src/providers/hana/qgshanaprovider.cpp
Expand Up @@ -1567,7 +1567,7 @@ QgsCoordinateReferenceSystem QgsHanaProvider::crs() const
return srs;
}

QgsVectorLayerExporter::ExportError QgsHanaProvider::createEmptyLayer(
Qgis::VectorExportResult QgsHanaProvider::createEmptyLayer(
const QString &uri,
const QgsFields &fields,
QgsWkbTypes::Type wkbType,
Expand All @@ -1584,7 +1584,7 @@ QgsVectorLayerExporter::ExportError QgsHanaProvider::createEmptyLayer(
{
if ( errorMessage )
*errorMessage = QObject::tr( "Connection to database failed" );
return QgsVectorLayerExporter::ErrConnectionFailed;
return Qgis::VectorExportResult::ErrorConnectionFailed;
}

QString schemaName = dsUri.schema();
Expand All @@ -1594,7 +1594,7 @@ QgsVectorLayerExporter::ExportError QgsHanaProvider::createEmptyLayer(
{
if ( errorMessage )
*errorMessage = QObject::tr( "Schema name cannot be empty" );
return QgsVectorLayerExporter::ErrCreateLayer;
return Qgis::VectorExportResult::ErrorCreatingLayer;
}

QString geometryColumn = dsUri.geometryColumn();
Expand Down Expand Up @@ -1637,7 +1637,7 @@ QgsVectorLayerExporter::ExportError QgsHanaProvider::createEmptyLayer(
{
if ( errorMessage )
*errorMessage = QgsHanaUtils::formatErrorMessage( ex.what(), true );
return QgsVectorLayerExporter::ErrCreateLayer;
return Qgis::VectorExportResult::ErrorCreatingLayer;
}
}
}
Expand All @@ -1652,7 +1652,7 @@ QgsVectorLayerExporter::ExportError QgsHanaProvider::createEmptyLayer(
{
if ( errorMessage )
*errorMessage = QgsHanaUtils::formatErrorMessage( ex.what(), true );
return QgsVectorLayerExporter::ErrCreateLayer;
return Qgis::VectorExportResult::ErrorCreatingLayer;
}

if ( numTables != 0 )
Expand All @@ -1662,14 +1662,14 @@ QgsVectorLayerExporter::ExportError QgsHanaProvider::createEmptyLayer(
QString sql = QStringLiteral( "DROP TABLE %1.%2" )
.arg( QgsHanaUtils::quotedIdentifier( schemaName ), QgsHanaUtils::quotedIdentifier( tableName ) );
if ( !conn->execute( sql, errorMessage ) )
return QgsVectorLayerExporter::ErrCreateLayer;
return Qgis::VectorExportResult::ErrorCreatingLayer;
}
else
{
if ( errorMessage )
*errorMessage = QObject::tr( "Table %1.%2 already exists" ).arg( schemaName, tableName );

return QgsVectorLayerExporter::ErrCreateLayer;
return Qgis::VectorExportResult::ErrorCreatingLayer;
}
}

Expand All @@ -1686,7 +1686,7 @@ QgsVectorLayerExporter::ExportError QgsHanaProvider::createEmptyLayer(
}

if ( !conn->execute( sql, errorMessage ) )
return QgsVectorLayerExporter::ErrCreateLayer;
return Qgis::VectorExportResult::ErrorCreatingLayer;

dsUri.setDataSource( dsUri.schema(), dsUri.table(), geometryColumn, dsUri.sql(), primaryKey );
dsUri.setSrid( QString::number( srid ) );
Expand All @@ -1699,7 +1699,7 @@ QgsVectorLayerExporter::ExportError QgsHanaProvider::createEmptyLayer(
if ( errorMessage )
*errorMessage = QObject::tr( "Loading of the layer %1 failed" ).arg( schemaTableName );

return QgsVectorLayerExporter::ErrInvalidLayer;
return Qgis::VectorExportResult::ErrorInvalidLayer;
}

// add fields to the layer
Expand All @@ -1722,7 +1722,7 @@ QgsVectorLayerExporter::ExportError QgsHanaProvider::createEmptyLayer(
if ( errorMessage )
*errorMessage = QObject::tr( "Unsupported type for field %1" ).arg( fld.name() );

return QgsVectorLayerExporter::ErrAttributeTypeUnsupported;
return Qgis::VectorExportResult::ErrorAttributeTypeUnsupported;
}

if ( fld.name() != primaryKey )
Expand All @@ -1737,11 +1737,11 @@ QgsVectorLayerExporter::ExportError QgsHanaProvider::createEmptyLayer(
if ( errorMessage )
*errorMessage = QObject::tr( "Creation of fields failed" );

return QgsVectorLayerExporter::ErrAttributeCreationFailed;
return Qgis::VectorExportResult::ErrorAttributeCreationFailed;
}
}

return QgsVectorLayerExporter::NoError;
return Qgis::VectorExportResult::Success;
}

QgsHanaProviderMetadata::QgsHanaProviderMetadata()
Expand All @@ -1767,7 +1767,7 @@ QList< QgsDataItemProvider *> QgsHanaProviderMetadata::dataItemProviders() const
return providers;
}

QgsVectorLayerExporter::ExportError QgsHanaProviderMetadata::createEmptyLayer(
Qgis::VectorExportResult QgsHanaProviderMetadata::createEmptyLayer(
const QString &uri,
const QgsFields &fields,
QgsWkbTypes::Type wkbType,
Expand Down
4 changes: 2 additions & 2 deletions src/providers/hana/qgshanaprovider.h
Expand Up @@ -94,7 +94,7 @@ class QgsHanaProvider final : public QgsVectorDataProvider
QgsCoordinateReferenceSystem crs() const override;

//! Import a vector layer into the database
static QgsVectorLayerExporter::ExportError createEmptyLayer(
static Qgis::VectorExportResult createEmptyLayer(
const QString &uri,
const QgsFields &fields,
QgsWkbTypes::Type wkbType,
Expand Down Expand Up @@ -180,7 +180,7 @@ class QgsHanaProviderMetadata : public QgsProviderMetadata

QgsHanaProvider *createProvider( const QString &uri, const QgsDataProvider::ProviderOptions &options, QgsDataProvider::ReadFlags flags = QgsDataProvider::ReadFlags() ) override;

QgsVectorLayerExporter::ExportError createEmptyLayer(
Qgis::VectorExportResult createEmptyLayer(
const QString &uri,
const QgsFields &fields,
QgsWkbTypes::Type wkbType,
Expand Down
23 changes: 12 additions & 11 deletions src/providers/oracle/qgsoracleproviderconnection.cpp
Expand Up @@ -20,6 +20,7 @@
#include "qgsoracleprovider.h"
#include "qgsexception.h"
#include "qgsapplication.h"
#include "qgsfeedback.h"

#include <QSqlRecord>
#include <QSqlField>
Expand Down Expand Up @@ -275,17 +276,17 @@ void QgsOracleProviderConnection::createVectorTable( const QString &schema,
}
QMap<int, int> map;
QString errCause;
const QgsVectorLayerExporter::ExportError errCode = QgsOracleProvider::createEmptyLayer(
newUri.uri(),
fields,
wkbType,
srs,
overwrite,
map,
errCause,
options
);
if ( errCode != QgsVectorLayerExporter::ExportError::NoError )
const Qgis::VectorExportResult res = QgsOracleProvider::createEmptyLayer(
newUri.uri(),
fields,
wkbType,
srs,
overwrite,
map,
errCause,
options
);
if ( res != Qgis::VectorExportResult::Success )
throw QgsProviderConnectionException( QObject::tr( "An error occurred while creating the vector layer: %1" ).arg( errCause ) );
}

Expand Down

0 comments on commit 9589813

Please sign in to comment.