Fix #17412 Sorting fixed, no troubles when editing after sorting

Issue was, that the cellchange is triggered at re-sorting or renaming something in re-sorted table - so there was a bug that referenced to the row instead of the index
qgis · Nov 8, 2017 · 9339615 · 9339615
1 parent 3780223
commit 9339615
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/src/app/qgsfieldsproperties.cpp b/src/app/qgsfieldsproperties.cpp
@@ -776,15 +776,17 @@ void QgsFieldsProperties::attributesListCellChanged( int row, int column )
   }
   else if ( column == attrNameCol && mLayer && mLayer->isEditable() )
   {
+    int idx = mIndexedWidgets.indexOf( mFieldsList->item( row, attrIdCol ) );
+
     QTableWidgetItem *nameItem = mFieldsList->item( row, column );
     if ( !nameItem ||
          nameItem->text().isEmpty() ||
-         !mLayer->fields().exists( row ) ||
-         mLayer->fields().at( row ).name() == nameItem->text() )
+         !mLayer->fields().exists( idx ) ||
+         mLayer->fields().at( idx ).name() == nameItem->text() )
       return;
 
     mLayer->beginEditCommand( tr( "Rename attribute" ) );
-    if ( mLayer->renameAttribute( row,  nameItem->text() ) )
+    if ( mLayer->renameAttribute( idx,  nameItem->text() ) )
     {
       mLayer->endEditCommand();
     }