coverity fixes

jef-n · jef-n · commit 92af85b7a2f3 · 2015-07-07T20:16:26.000+02:00
diff --git a/src/core/qgspallabeling.cpp b/src/core/qgspallabeling.cpp
@@ -4052,7 +4052,7 @@ void QgsPalLabeling::drawLabeling( QgsRenderContext& context )
   double bbox[] = { extent.xMinimum(), extent.yMinimum(), extent.xMaximum(), extent.yMaximum() };
 
   std::list<LabelPosition*>* labels;
-  pal::Problem* problem;
+  pal::Problem *problem;
   try
   {
     problem = mPal->extractProblem( scale, bbox );
@@ -4066,7 +4066,10 @@ void QgsPalLabeling::drawLabeling( QgsRenderContext& context )
   }
 
   if ( context.renderingStopped() )
+  {
+    delete problem;
     return; // it has been cancelled
+  }
 
 #if 1 // XXX strk
   // features are pre-rotated but not scaled/translated,
diff --git a/tests/src/core/testqgscomposerdd.cpp b/tests/src/core/testqgscomposerdd.cpp
@@ -39,6 +39,7 @@ class TestQgsComposerDD : public QObject
   public:
     TestQgsComposerDD()
         : mComposition( 0 )
+        , mMapSettings( 0 )
         , mVectorLayer( 0 )
         , mAtlasMap( 0 )
         , mAtlas( 0 )
diff --git a/tests/src/core/testqgscomposergroup.cpp b/tests/src/core/testqgscomposergroup.cpp
@@ -31,6 +31,7 @@ class TestQgsComposerGroup : public QObject
   public:
     TestQgsComposerGroup()
         : mComposition( 0 )
+        , mMapSettings( 0 )
         , mItem1( 0 )
         , mItem2( 0 )
         , mGroup( 0 )
diff --git a/tests/src/core/testqgscomposermap.cpp b/tests/src/core/testqgscomposermap.cpp
@@ -34,6 +34,7 @@ class TestQgsComposerMap : public QObject
     TestQgsComposerMap()
         : mComposition( 0 )
         , mComposerMap( 0 )
+        , mMapSettings( 0 )
         , mRasterLayer( 0 )
     {}
 
diff --git a/tests/src/core/testqgscomposermapgrid.cpp b/tests/src/core/testqgscomposermapgrid.cpp
@@ -66,17 +66,18 @@ class TestQgsComposerMapGrid : public QObject
 };
 
 TestQgsComposerMapGrid::TestQgsComposerMapGrid()
-    : mComposition( NULL )
-    , mComposerMap( NULL )
+    : mComposition( 0 )
+    , mComposerMap( 0 )
+    , mMapSettings( 0 )
 {
-  QgsApplication::init();
-  QgsApplication::initQgis();
-
-  mMapSettings = new QgsMapSettings();
 }
 
 void TestQgsComposerMapGrid::initTestCase()
 {
+  QgsApplication::init();
+  QgsApplication::initQgis();
+  mMapSettings = new QgsMapSettings();
+
   mReport = "<h1>Composer Map Grid Tests</h1>\n";
 }
 
diff --git a/tests/src/core/testqgscomposermodel.cpp b/tests/src/core/testqgscomposermodel.cpp
@@ -31,6 +31,7 @@ class TestQgsComposerModel : public QObject
   public:
     TestQgsComposerModel()
         : mComposition( 0 )
+        , mMapSettings( 0 )
         , mItem1( 0 )
         , mItem2( 0 )
         , mItem3( 0 )
diff --git a/tests/src/core/testqgscomposerpaper.cpp b/tests/src/core/testqgscomposerpaper.cpp
@@ -40,6 +40,7 @@ class TestQgsComposerPaper : public QObject
         , mMarkerLine( 0 )
         , mFillSymbol( 0 )
         , mMarkerLineSymbol( 0 )
+        , mMapSettings( 0 )
     {}
 
   private slots:
diff --git a/tests/src/core/testqgscomposershapes.cpp b/tests/src/core/testqgscomposershapes.cpp
@@ -36,6 +36,7 @@ class TestQgsComposerShapes : public QObject
     TestQgsComposerShapes()
         : mComposition( 0 )
         , mComposerShape( 0 )
+        , mMapSettings( 0 )
         , mSimpleFill( 0 )
         , mFillSymbol( 0 )
     {}

Original file line number	Diff line number	Diff line change
`@@ -66,17 +66,18 @@ class TestQgsComposerMapGrid : public QObject`
`66`	`66`	`};`
`67`	`67`
`68`	`68`	`TestQgsComposerMapGrid::TestQgsComposerMapGrid()`
`69`		`- : mComposition( NULL )`
`70`		`- , mComposerMap( NULL )`
	`69`	`+ : mComposition( 0 )`
	`70`	`+ , mComposerMap( 0 )`
	`71`	`+ , mMapSettings( 0 )`
`71`	`72`	`{`
`72`		`- QgsApplication::init();`
`73`		`- QgsApplication::initQgis();`
`74`		`-`
`75`		`- mMapSettings = new QgsMapSettings();`
`76`	`73`	`}`
`77`	`74`
`78`	`75`	`void TestQgsComposerMapGrid::initTestCase()`
`79`	`76`	`{`
	`77`	`+ QgsApplication::init();`
	`78`	`+ QgsApplication::initQgis();`
	`79`	`+ mMapSettings = new QgsMapSettings();`
	`80`	`+`
`80`	`81`	`mReport = "<h1>Composer Map Grid Tests</h1>\n";`
`81`	`82`	`}`
`82`	`83`