Fix some clazy warnings

nyalldawson · nyalldawson · commit 8fac4d89bd5b · 2018-07-22T07:21:58.000+10:00
diff --git a/src/core/qgspointlocator.cpp b/src/core/qgspointlocator.cpp
@@ -587,13 +587,13 @@ class QgsPointLocator_DumpTree : public SpatialIndex::IQueryStrategy
       if ( !n )
         return;
 
-      QgsDebugMsg( QString( "NODE: %1" ).arg( n->getIdentifier() ) );
+      QgsDebugMsgLevel( QStringLiteral( "NODE: %1" ).arg( n->getIdentifier() ), 4 );
       if ( n->getLevel() > 0 )
       {
         // inner nodes
         for ( uint32_t cChild = 0; cChild < n->getChildrenCount(); cChild++ )
         {
-          QgsDebugMsg( QString( "- CH: %1" ).arg( n->getChildIdentifier( cChild ) ) );
+          QgsDebugMsgLevel( QStringLiteral( "- CH: %1" ).arg( n->getChildIdentifier( cChild ) ), 4 );
           ids.push( n->getChildIdentifier( cChild ) );
         }
       }
@@ -602,7 +602,7 @@ class QgsPointLocator_DumpTree : public SpatialIndex::IQueryStrategy
         // leaves
         for ( uint32_t cChild = 0; cChild < n->getChildrenCount(); cChild++ )
         {
-          QgsDebugMsg( QString( "- L: %1" ).arg( n->getChildIdentifier( cChild ) ) );
+          QgsDebugMsgLevel( QStringLiteral( "- L: %1" ).arg( n->getChildIdentifier( cChild ) ), 4 );
         }
       }
 
@@ -767,7 +767,7 @@ bool QgsPointLocator::rebuildIndex( int maxFeaturesToIndex )
       {
         Q_UNUSED( e );
         // See https://issues.qgis.org/issues/12634
-        QgsDebugMsg( QString( "could not transform geometry to map, skipping the snap for it (%1)" ).arg( e.what() ) );
+        QgsDebugMsg( QStringLiteral( "could not transform geometry to map, skipping the snap for it (%1)" ).arg( e.what() ) );
         continue;
       }
     }
@@ -877,7 +877,7 @@ void QgsPointLocator::onFeatureAdded( QgsFeatureId fid )
       {
         Q_UNUSED( e );
         // See https://issues.qgis.org/issues/12634
-        QgsDebugMsg( QString( "could not transform geometry to map, skipping the snap for it (%1)" ).arg( e.what() ) );
+        QgsDebugMsg( QStringLiteral( "could not transform geometry to map, skipping the snap for it (%1)" ).arg( e.what() ) );
         return;
       }
     }

Original file line number	Diff line number	Diff line change
`@@ -587,13 +587,13 @@ class QgsPointLocator_DumpTree : public SpatialIndex::IQueryStrategy`
`587`	`587`	`if ( !n )`
`588`	`588`	`return;`
`589`	`589`
`590`		`- QgsDebugMsg( QString( "NODE: %1" ).arg( n->getIdentifier() ) );`
	`590`	`+ QgsDebugMsgLevel( QStringLiteral( "NODE: %1" ).arg( n->getIdentifier() ), 4 );`
`591`	`591`	`if ( n->getLevel() > 0 )`
`592`	`592`	`{`
`593`	`593`	`// inner nodes`
`594`	`594`	`for ( uint32_t cChild = 0; cChild < n->getChildrenCount(); cChild++ )`
`595`	`595`	`{`
`596`		`- QgsDebugMsg( QString( "- CH: %1" ).arg( n->getChildIdentifier( cChild ) ) );`
	`596`	`+ QgsDebugMsgLevel( QStringLiteral( "- CH: %1" ).arg( n->getChildIdentifier( cChild ) ), 4 );`
`597`	`597`	`ids.push( n->getChildIdentifier( cChild ) );`
`598`	`598`	`}`
`599`	`599`	`}`
`@@ -602,7 +602,7 @@ class QgsPointLocator_DumpTree : public SpatialIndex::IQueryStrategy`
`602`	`602`	`// leaves`
`603`	`603`	`for ( uint32_t cChild = 0; cChild < n->getChildrenCount(); cChild++ )`
`604`	`604`	`{`
`605`		`- QgsDebugMsg( QString( "- L: %1" ).arg( n->getChildIdentifier( cChild ) ) );`
	`605`	`+ QgsDebugMsgLevel( QStringLiteral( "- L: %1" ).arg( n->getChildIdentifier( cChild ) ), 4 );`
`606`	`606`	`}`
`607`	`607`	`}`
`608`	`608`
`@@ -767,7 +767,7 @@ bool QgsPointLocator::rebuildIndex( int maxFeaturesToIndex )`
`767`	`767`	`{`
`768`	`768`	`Q_UNUSED( e );`
`769`	`769`	`// See https://issues.qgis.org/issues/12634`
`770`		`- QgsDebugMsg( QString( "could not transform geometry to map, skipping the snap for it (%1)" ).arg( e.what() ) );`
	`770`	`+ QgsDebugMsg( QStringLiteral( "could not transform geometry to map, skipping the snap for it (%1)" ).arg( e.what() ) );`
`771`	`771`	`continue;`
`772`	`772`	`}`
`773`	`773`	`}`
`@@ -877,7 +877,7 @@ void QgsPointLocator::onFeatureAdded( QgsFeatureId fid )`
`877`	`877`	`{`
`878`	`878`	`Q_UNUSED( e );`
`879`	`879`	`// See https://issues.qgis.org/issues/12634`
`880`		`- QgsDebugMsg( QString( "could not transform geometry to map, skipping the snap for it (%1)" ).arg( e.what() ) );`
	`880`	`+ QgsDebugMsg( QStringLiteral( "could not transform geometry to map, skipping the snap for it (%1)" ).arg( e.what() ) );`
`881`	`881`	`return;`
`882`	`882`	`}`
`883`	`883`	`}`