Use mkdtemp for temporary directory and clean at the end of the test

qgis · Jan 11, 2019 · 8efc689 · 8efc689
1 parent 99076c9
commit 8efc689
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/tests/src/python/test_provider_spatialite.py b/tests/src/python/test_provider_spatialite.py
@@ -757,9 +757,7 @@ def testDecodeUri(self):
     def testPKNotInt(self):
         """ Check when primary key is not an integer """
         # create test db
-        dbname = os.path.join(tempfile.gettempdir(), "test_pknotint.sqlite")
-        if os.path.exists(dbname):
-            os.remove(dbname)
+        dbname = os.path.join(tempfile.mkdtemp(), "test_pknotint.sqlite")
         con = spatialite_connect(dbname, isolation_level=None)
         cur = con.cursor()
 
@@ -805,6 +803,9 @@ def testPKNotInt(self):
 
         con.close()
 
+        basepath, filename = os.path.split(dbname)
+        shutil.rmtree(basepath)
+
     def testLoadStyle(self):
         """Check that we can store and load a style"""