Skip to content

Commit

Permalink
Add a method to transform QgsAnnotationItems using a QTransform
Browse files Browse the repository at this point in the history
transform
  • Loading branch information
nyalldawson committed Sep 7, 2021
1 parent 4f1fc3b commit 8d1f2bf
Show file tree
Hide file tree
Showing 20 changed files with 103 additions and 5 deletions.
Expand Up @@ -82,6 +82,15 @@ Returns the bounding box of the item's geographic location, in the parent layer'
virtual QgsRectangle boundingBox( QgsRenderContext &context ) const;
%Docstring
Returns the bounding box of the item's geographic location, in the parent layer's coordinate reference system.
%End

virtual bool transform( const QTransform &transform ) = 0;
%Docstring
Transforms the item's geometry using the specified ``transform``.

Returns ``True`` if the transformation was successful.

.. versionadded:: 3.22
%End

virtual void render( QgsRenderContext &context, QgsFeedback *feedback ) = 0;
Expand Down
Expand Up @@ -37,6 +37,8 @@ Constructor for QgsAnnotationLineItem, with the specified ``linestring``.

virtual QList< QgsAnnotationItemNode > nodes() const;

virtual bool transform( const QTransform &transform );


static QgsAnnotationLineItem *create() /Factory/;
%Docstring
Expand Down
Expand Up @@ -53,6 +53,8 @@ Creates a new marker annotation item.

virtual QgsRectangle boundingBox( QgsRenderContext &context ) const;

virtual bool transform( const QTransform &transform );


QgsPointXY geometry() const;
%Docstring
Expand Down
Expand Up @@ -53,6 +53,8 @@ Creates a new text at point annotation item.

virtual QList< QgsAnnotationItemNode > nodes() const;

virtual bool transform( const QTransform &transform );


QgsPointXY point() const;
%Docstring
Expand Down
Expand Up @@ -37,6 +37,8 @@ Constructor for QgsAnnotationPolygonItem, with the specified ``polygon`` geometr

virtual QList< QgsAnnotationItemNode > nodes() const;

virtual bool transform( const QTransform &transform );


static QgsAnnotationPolygonItem *create() /Factory/;
%Docstring
Expand Down
9 changes: 9 additions & 0 deletions src/core/annotations/qgsannotationitem.h
Expand Up @@ -111,6 +111,15 @@ class CORE_EXPORT QgsAnnotationItem
*/
virtual QgsRectangle boundingBox( QgsRenderContext &context ) const { Q_UNUSED( context ) return boundingBox();}

/**
* Transforms the item's geometry using the specified \a transform.
*
* Returns TRUE if the transformation was successful.
*
* \since QGIS 3.22
*/
virtual bool transform( const QTransform &transform ) = 0;

/**
* Renders the item to the specified render \a context.
*
Expand Down
6 changes: 6 additions & 0 deletions src/core/annotations/qgsannotationlineitem.cpp
Expand Up @@ -90,6 +90,12 @@ QList<QgsAnnotationItemNode> QgsAnnotationLineItem::nodes() const
return res;
}

bool QgsAnnotationLineItem::transform( const QTransform &transform )
{
mCurve->transform( transform );
return true;
}

QgsAnnotationLineItem *QgsAnnotationLineItem::create()
{
return new QgsAnnotationLineItem( new QgsLineString() );
Expand Down
1 change: 1 addition & 0 deletions src/core/annotations/qgsannotationlineitem.h
Expand Up @@ -44,6 +44,7 @@ class CORE_EXPORT QgsAnnotationLineItem : public QgsAnnotationItem
void render( QgsRenderContext &context, QgsFeedback *feedback ) override;
bool writeXml( QDomElement &element, QDomDocument &document, const QgsReadWriteContext &context ) const override;
QList< QgsAnnotationItemNode > nodes() const override;
bool transform( const QTransform &transform ) override;

/**
* Creates a new linestring annotation item.
Expand Down
6 changes: 6 additions & 0 deletions src/core/annotations/qgsannotationmarkeritem.cpp
Expand Up @@ -140,6 +140,12 @@ QgsRectangle QgsAnnotationMarkerItem::boundingBox( QgsRenderContext &context ) c
return context.coordinateTransform().transformBoundingBox( boundsMapUnits, QgsCoordinateTransform::ReverseTransform );
}

bool QgsAnnotationMarkerItem::transform( const QTransform &transform )
{
mPoint.transform( transform );
return true;
}

const QgsMarkerSymbol *QgsAnnotationMarkerItem::symbol() const
{
return mSymbol.get();
Expand Down
1 change: 1 addition & 0 deletions src/core/annotations/qgsannotationmarkeritem.h
Expand Up @@ -54,6 +54,7 @@ class CORE_EXPORT QgsAnnotationMarkerItem : public QgsAnnotationItem
QgsAnnotationMarkerItem *clone() override SIP_FACTORY;
QgsRectangle boundingBox() const override;
QgsRectangle boundingBox( QgsRenderContext &context ) const override;
bool transform( const QTransform &transform ) override;

/**
* Returns the point geometry of the marker.
Expand Down
9 changes: 9 additions & 0 deletions src/core/annotations/qgsannotationpointtextitem.cpp
Expand Up @@ -137,6 +137,15 @@ QList<QgsAnnotationItemNode> QgsAnnotationPointTextItem::nodes() const
return { QgsAnnotationItemNode( mPoint, Qgis::AnnotationItemNodeType::VertexHandle )};
}

bool QgsAnnotationPointTextItem::transform( const QTransform &transform )
{
double x = mPoint.x();
double y = mPoint.y();
transform.map( mPoint.x(), mPoint.y(), &x, &y );
mPoint.set( x, y );
return true;
}

QgsTextFormat QgsAnnotationPointTextItem::format() const
{
return mTextFormat;
Expand Down
1 change: 1 addition & 0 deletions src/core/annotations/qgsannotationpointtextitem.h
Expand Up @@ -55,6 +55,7 @@ class CORE_EXPORT QgsAnnotationPointTextItem : public QgsAnnotationItem
QgsRectangle boundingBox() const override;
QgsRectangle boundingBox( QgsRenderContext &context ) const override;
QList< QgsAnnotationItemNode > nodes() const override;
bool transform( const QTransform &transform ) override;

/**
* Returns the point location of the text.
Expand Down
6 changes: 6 additions & 0 deletions src/core/annotations/qgsannotationpolygonitem.cpp
Expand Up @@ -121,6 +121,12 @@ QList<QgsAnnotationItemNode> QgsAnnotationPolygonItem::nodes() const
return res;
}

bool QgsAnnotationPolygonItem::transform( const QTransform &transform )
{
mPolygon->transform( transform );
return true;
}

QgsAnnotationPolygonItem *QgsAnnotationPolygonItem::create()
{
return new QgsAnnotationPolygonItem( new QgsPolygon() );
Expand Down
1 change: 1 addition & 0 deletions src/core/annotations/qgsannotationpolygonitem.h
Expand Up @@ -43,6 +43,7 @@ class CORE_EXPORT QgsAnnotationPolygonItem : public QgsAnnotationItem
void render( QgsRenderContext &context, QgsFeedback *feedback ) override;
bool writeXml( QDomElement &element, QDomDocument &document, const QgsReadWriteContext &context ) const override;
QList< QgsAnnotationItemNode > nodes() const override;
bool transform( const QTransform &transform ) override;

/**
* Creates a new polygon annotation item.
Expand Down
5 changes: 5 additions & 0 deletions tests/src/core/testqgsannotationitemregistry.cpp
Expand Up @@ -52,6 +52,11 @@ class TestItem : public QgsAnnotationItem
return new TestItem();
}

bool transform( const QTransform & ) override
{
return true;
}

bool writeXml( QDomElement &, QDomDocument &, const QgsReadWriteContext & ) const override
{
return true;
Expand Down
2 changes: 1 addition & 1 deletion tests/src/gui/testqgsannotationitemguiregistry.cpp
Expand Up @@ -68,7 +68,7 @@ class TestItem : public QgsAnnotationItem // clazy:exclude=missing-qobject-macro
void render( QgsRenderContext &, QgsFeedback * ) override {}
bool writeXml( QDomElement &, QDomDocument &, const QgsReadWriteContext & ) const override { return true; }
bool readXml( const QDomElement &, const QgsReadWriteContext & ) override { return true; }

bool transform( const QTransform & ) override { return true; }
};

class TestItemWidget: public QgsAnnotationItemBaseWidget
Expand Down
11 changes: 10 additions & 1 deletion tests/src/python/test_qgsannotationlineitem.py
Expand Up @@ -18,7 +18,8 @@
QDir)
from qgis.PyQt.QtGui import (QImage,
QPainter,
QColor)
QColor,
QTransform)
from qgis.core import (QgsMapSettings,
QgsCoordinateTransform,
QgsProject,
Expand Down Expand Up @@ -79,6 +80,14 @@ def test_nodes(self):
QgsAnnotationItemNode(QgsPointXY(14, 13), Qgis.AnnotationItemNodeType.VertexHandle),
QgsAnnotationItemNode(QgsPointXY(14, 15), Qgis.AnnotationItemNodeType.VertexHandle)])

def test_transform(self):
item = QgsAnnotationLineItem(QgsLineString([QgsPoint(12, 13), QgsPoint(14, 13), QgsPoint(14, 15)]))
self.assertEqual(item.geometry().asWkt(), 'LineString (12 13, 14 13, 14 15)')

transform = QTransform.fromTranslate(100, 200)
item.transform(transform)
self.assertEqual(item.geometry().asWkt(), 'LineString (112 213, 114 213, 114 215)')

def testReadWriteXml(self):
doc = QDomDocument("testdoc")
elem = doc.createElement('test')
Expand Down
11 changes: 10 additions & 1 deletion tests/src/python/test_qgsannotationmarkeritem.py
Expand Up @@ -18,7 +18,8 @@
QDir)
from qgis.PyQt.QtGui import (QImage,
QPainter,
QColor)
QColor,
QTransform)
from qgis.core import (QgsMapSettings,
QgsCoordinateTransform,
QgsProject,
Expand Down Expand Up @@ -77,6 +78,14 @@ def test_nodes(self):
item = QgsAnnotationMarkerItem(QgsPoint(12, 13))
self.assertEqual(item.nodes(), [QgsAnnotationItemNode(QgsPointXY(12, 13), Qgis.AnnotationItemNodeType.VertexHandle)])

def test_transform(self):
item = QgsAnnotationMarkerItem(QgsPoint(12, 13))
self.assertEqual(item.geometry().asWkt(), 'POINT(12 13)')

transform = QTransform.fromTranslate(100, 200)
item.transform(transform)
self.assertEqual(item.geometry().asWkt(), 'POINT(112 213)')

def testReadWriteXml(self):
doc = QDomDocument("testdoc")
elem = doc.createElement('test')
Expand Down
11 changes: 10 additions & 1 deletion tests/src/python/test_qgsannotationpointtextitem.py
Expand Up @@ -19,7 +19,8 @@
Qt)
from qgis.PyQt.QtGui import (QImage,
QPainter,
QColor)
QColor,
QTransform)
from qgis.core import (QgsMapSettings,
QgsCoordinateTransform,
QgsProject,
Expand Down Expand Up @@ -88,6 +89,14 @@ def test_nodes(self):
item = QgsAnnotationPointTextItem('my text', QgsPointXY(12, 13))
self.assertEqual(item.nodes(), [QgsAnnotationItemNode(QgsPointXY(12, 13), Qgis.AnnotationItemNodeType.VertexHandle)])

def test_transform(self):
item = QgsAnnotationPointTextItem('my text', QgsPointXY(12, 13))
self.assertEqual(item.point().asWkt(), 'POINT(12 13)')

transform = QTransform.fromTranslate(100, 200)
item.transform(transform)
self.assertEqual(item.point().asWkt(), 'POINT(112 213)')

def testReadWriteXml(self):
doc = QDomDocument("testdoc")
elem = doc.createElement('test')
Expand Down
11 changes: 10 additions & 1 deletion tests/src/python/test_qgsannotationpolygonitem.py
Expand Up @@ -18,7 +18,8 @@
QDir)
from qgis.PyQt.QtGui import (QImage,
QPainter,
QColor)
QColor,
QTransform)
from qgis.core import (QgsMapSettings,
QgsCoordinateTransform,
QgsProject,
Expand Down Expand Up @@ -82,6 +83,14 @@ def test_nodes(self):
QgsAnnotationItemNode(QgsPointXY(14, 13), Qgis.AnnotationItemNodeType.VertexHandle),
QgsAnnotationItemNode(QgsPointXY(14, 15), Qgis.AnnotationItemNodeType.VertexHandle)])

def test_transform(self):
item = QgsAnnotationPolygonItem(QgsPolygon(QgsLineString([QgsPoint(12, 13), QgsPoint(14, 13), QgsPoint(14, 15), QgsPoint(12, 13)])))
self.assertEqual(item.geometry().asWkt(), 'Polygon ((12 13, 14 13, 14 15, 12 13))')

transform = QTransform.fromTranslate(100, 200)
item.transform(transform)
self.assertEqual(item.geometry().asWkt(), 'Polygon ((112 213, 114 213, 114 215, 112 213))')

def testReadWriteXml(self):
doc = QDomDocument("testdoc")
elem = doc.createElement('test')
Expand Down

0 comments on commit 8d1f2bf

Please sign in to comment.