[Geometry checker] Don't recheck any features if fixed error resulted…

… in no changes
qgis · Oct 23, 2017 · 8cefc65 · 8cefc65
1 parent e089b3b
commit 8cefc65
Showing 1 changed file with 2 additions and 15 deletions.
diff --git a/src/analysis/vector/geometry_checker/qgsgeometrychecker.cpp b/src/analysis/vector/geometry_checker/qgsgeometrychecker.cpp
@@ -113,7 +113,8 @@ bool QgsGeometryChecker::fixError( QgsGeometryCheckError *error, int method, boo
     return false;
   }
 
-  if ( error->resolutionMessage() == tr( "No action" ) )
+  // If nothing was changed, stop here
+  if ( changes.isEmpty() )
   {
     return true;
   }
@@ -188,20 +189,6 @@ bool QgsGeometryChecker::fixError( QgsGeometryCheckError *error, int method, boo
     }
   }
 
-  // Remove just-fixed error from newly-found errors if no changes occurred (needed in case error was fixed with "no change")
-  if ( changes.isEmpty() )
-  {
-    for ( QgsGeometryCheckError *recheckErr : recheckErrors )
-    {
-      if ( recheckErr->isEqual( error ) )
-      {
-        recheckErrors.removeAll( recheckErr );
-        delete recheckErr;
-        break;
-      }
-    }
-  }
-
   // Go through error list, update other errors of the checked feature
   for ( QgsGeometryCheckError *err : mCheckErrors )
   {