Fix leak in add map tool

nyalldawson · nyalldawson · commit 8ce9930f4a06 · 2015-09-01T16:07:10.000+10:00
diff --git a/python/core/geometry/qgsgeometry.sip b/python/core/geometry/qgsgeometry.sip
@@ -47,7 +47,7 @@ class QgsGeometry
      * geom is transferred.
      * @note added in QGIS 2.10
      */
-    QgsGeometry( QgsAbstractGeometryV2* geom /Transfer/ );
+    explicit QgsGeometry( QgsAbstractGeometryV2* geom /Transfer/ );
 
     //! Destructor
     ~QgsGeometry();
diff --git a/src/app/qgsmaptooladdfeature.cpp b/src/app/qgsmaptooladdfeature.cpp
@@ -241,7 +241,7 @@ void QgsMapToolAddFeature::canvasMapReleaseEvent( QgsMapMouseEvent* e )
           poly = new QgsPolygonV2();
         }
         poly->setExteriorRing( curveToAdd );
-        f->setGeometry( poly );
+        f->setGeometry( new QgsGeometry( poly ) );
 
         int avoidIntersectionsReturn = f->geometry()->avoidIntersections();
         if ( avoidIntersectionsReturn == 1 )
diff --git a/src/core/geometry/qgsgeometry.h b/src/core/geometry/qgsgeometry.h
@@ -90,7 +90,7 @@ class CORE_EXPORT QgsGeometry
      * geom is transferred.
      * @note added in QGIS 2.10
      */
-    QgsGeometry( QgsAbstractGeometryV2* geom );
+    explicit QgsGeometry( QgsAbstractGeometryV2* geom );
 
     //! Destructor
     ~QgsGeometry();

Original file line number	Diff line number	Diff line change
`@@ -241,7 +241,7 @@ void QgsMapToolAddFeature::canvasMapReleaseEvent( QgsMapMouseEvent* e )`
`241`	`241`	`poly = new QgsPolygonV2();`
`242`	`242`	`}`
`243`	`243`	`poly->setExteriorRing( curveToAdd );`
`244`		`- f->setGeometry( poly );`
	`244`	`+ f->setGeometry( new QgsGeometry( poly ) );`
`245`	`245`
`246`	`246`	`int avoidIntersectionsReturn = f->geometry()->avoidIntersections();`
`247`	`247`	`if ( avoidIntersectionsReturn == 1 )`