Fix QgsMapLayer::saveNamedProperty and QgsMapLayer::saveSldStyleV2

agiudiceandrea · nyalldawson · commit 8bc99010e0d8 · 2023-09-16T09:47:30.000+10:00
set resultFlag to False when the directory is not writable
diff --git a/src/core/qgsmaplayer.cpp b/src/core/qgsmaplayer.cpp
@@ -1392,6 +1392,7 @@ QString QgsMapLayer::saveNamedProperty( const QString &uri, QgsMapLayer::Propert
     const QFileInfo myDirInfo( myFileInfo.path() );  //excludes file name
     if ( !myDirInfo.isWritable() )
     {
+      resultFlag = false;
       return tr( "The directory containing your dataset needs to be writable!" );
     }
 
@@ -1698,6 +1699,7 @@ QString QgsMapLayer::saveSldStyle( const QString &uri, bool &resultFlag ) const
     const QFileInfo myDirInfo( myFileInfo.path() );  //excludes file name
     if ( !myDirInfo.isWritable() )
     {
+      resultFlag = false;
       return tr( "The directory containing your dataset needs to be writable!" );
     }
 

Original file line number	Diff line number	Diff line change
`@@ -1392,6 +1392,7 @@ QString QgsMapLayer::saveNamedProperty( const QString &uri, QgsMapLayer::Propert`
`1392`	`1392`	`const QFileInfo myDirInfo( myFileInfo.path() ); //excludes file name`
`1393`	`1393`	`if ( !myDirInfo.isWritable() )`
`1394`	`1394`	`{`
	`1395`	`+ resultFlag = false;`
`1395`	`1396`	`return tr( "The directory containing your dataset needs to be writable!" );`
`1396`	`1397`	`}`
`1397`	`1398`
`@@ -1698,6 +1699,7 @@ QString QgsMapLayer::saveSldStyle( const QString &uri, bool &resultFlag ) const`
`1698`	`1699`	`const QFileInfo myDirInfo( myFileInfo.path() ); //excludes file name`
`1699`	`1700`	`if ( !myDirInfo.isWritable() )`
`1700`	`1701`	`{`
	`1702`	`+ resultFlag = false;`
`1701`	`1703`	`return tr( "The directory containing your dataset needs to be writable!" );`
`1702`	`1704`	`}`
`1703`	`1705`