Skip to content

Commit 8b898b9

Browse files
committedJun 20, 2014
Forms: Hide "Hidden" widgets
Partly fixes #10649
1 parent 196a667 commit 8b898b9

File tree

1 file changed

+21
-17
lines changed

1 file changed

+21
-17
lines changed
 

‎src/gui/qgsattributeform.cpp

Lines changed: 21 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -378,26 +378,30 @@ void QgsAttributeForm::init()
378378
QString fieldName = mLayer->attributeDisplayName( idx );
379379

380380
const QString widgetType = mLayer->editorWidgetV2( idx );
381-
const QgsEditorWidgetConfig widgetConfig = mLayer->editorWidgetV2Config( idx );
382-
bool labelOnTop = mLayer->labelOnTop( idx );
383381

384-
// This will also create the widget
385-
QWidget *l = new QLabel( fieldName );
386-
QgsEditorWidgetWrapper* eww = QgsEditorWidgetRegistry::instance()->create( widgetType, mLayer, idx, widgetConfig, 0, this, mContext );
387-
QWidget *w = eww ? eww->widget() : new QLabel( QString( "<p style=\"color: red; font-style: italic;\">Failed to create widget with type '%1'</p>" ).arg( widgetType ) );
382+
if ( widgetType != "Hidden" )
383+
{
384+
const QgsEditorWidgetConfig widgetConfig = mLayer->editorWidgetV2Config( idx );
385+
bool labelOnTop = mLayer->labelOnTop( idx );
388386

389-
if ( eww )
390-
mWidgets.append( eww );
387+
// This will also create the widget
388+
QWidget *l = new QLabel( fieldName );
389+
QgsEditorWidgetWrapper* eww = QgsEditorWidgetRegistry::instance()->create( widgetType, mLayer, idx, widgetConfig, 0, this, mContext );
390+
QWidget *w = eww ? eww->widget() : new QLabel( QString( "<p style=\"color: red; font-style: italic;\">Failed to create widget with type '%1'</p>" ).arg( widgetType ) );
391391

392-
if ( labelOnTop )
393-
{
394-
gridLayout->addWidget( l, row++, 0, 1, 2 );
395-
gridLayout->addWidget( w, row++, 0, 1, 2 );
396-
}
397-
else
398-
{
399-
gridLayout->addWidget( l, row, 0 );
400-
gridLayout->addWidget( w, row++, 1 );
392+
if ( eww )
393+
mWidgets.append( eww );
394+
395+
if ( labelOnTop )
396+
{
397+
gridLayout->addWidget( l, row++, 0, 1, 2 );
398+
gridLayout->addWidget( w, row++, 0, 1, 2 );
399+
}
400+
else
401+
{
402+
gridLayout->addWidget( l, row, 0 );
403+
gridLayout->addWidget( w, row++, 1 );
404+
}
401405
}
402406
}
403407

0 commit comments

Comments
 (0)
Please sign in to comment.