Don't create undo commands for snap settings changes

nyalldawson · nyalldawson · commit 8b490dec55e3 · 2017-09-05T10:48:03.000+10:00
In practice this turns out to be undesirable - snapping changes
are more of a semi-permenant interface setting as opposed to something
which should be stored in the layout's undo history.
diff --git a/src/core/layout/qgslayoutsnapper.cpp b/src/core/layout/qgslayoutsnapper.cpp
@@ -31,23 +31,17 @@ QgsLayout *QgsLayoutSnapper::layout()
 
 void QgsLayoutSnapper::setSnapTolerance( const int snapTolerance )
 {
-  mLayout->undoStack()->beginCommand( this, QObject::tr( "Snap tolerance changed" ), UndoTolerance );
   mTolerance = snapTolerance;
-  mLayout->undoStack()->endCommand();
 }
 
 void QgsLayoutSnapper::setSnapToGrid( bool enabled )
 {
-  mLayout->undoStack()->beginCommand( this, QObject::tr( "Snap to grid changed" ), UndoSnapToGrid );
   mSnapToGrid = enabled;
-  mLayout->undoStack()->endCommand();
 }
 
 void QgsLayoutSnapper::setSnapToGuides( bool enabled )
 {
-  mLayout->undoStack()->beginCommand( this, QObject::tr( "Snap to guides changed" ), UndoSnapToGuides );
   mSnapToGuides = enabled;
-  mLayout->undoStack()->endCommand();
 }
 
 QPointF QgsLayoutSnapper::snapPoint( QPointF point, double scaleFactor, bool &snapped ) const

Original file line number	Diff line number	Diff line change
`@@ -31,23 +31,17 @@ QgsLayout *QgsLayoutSnapper::layout()`
`31`	`31`
`32`	`32`	`void QgsLayoutSnapper::setSnapTolerance( const int snapTolerance )`
`33`	`33`	`{`
`34`		`- mLayout->undoStack()->beginCommand( this, QObject::tr( "Snap tolerance changed" ), UndoTolerance );`
`35`	`34`	`mTolerance = snapTolerance;`
`36`		`- mLayout->undoStack()->endCommand();`
`37`	`35`	`}`
`38`	`36`
`39`	`37`	`void QgsLayoutSnapper::setSnapToGrid( bool enabled )`
`40`	`38`	`{`
`41`		`- mLayout->undoStack()->beginCommand( this, QObject::tr( "Snap to grid changed" ), UndoSnapToGrid );`
`42`	`39`	`mSnapToGrid = enabled;`
`43`		`- mLayout->undoStack()->endCommand();`
`44`	`40`	`}`
`45`	`41`
`46`	`42`	`void QgsLayoutSnapper::setSnapToGuides( bool enabled )`
`47`	`43`	`{`
`48`		`- mLayout->undoStack()->beginCommand( this, QObject::tr( "Snap to guides changed" ), UndoSnapToGuides );`
`49`	`44`	`mSnapToGuides = enabled;`
`50`		`- mLayout->undoStack()->endCommand();`
`51`	`45`	`}`
`52`	`46`
`53`	`47`	`QPointF QgsLayoutSnapper::snapPoint( QPointF point, double scaleFactor, bool &snapped ) const`