Skip to content

Commit

Permalink
[quick] Fix validity condition in QgsQuickFeatureLayerPair
Browse files Browse the repository at this point in the history
The extra condition enforcing that feature's geometry needs to have Z coordinate
if also its parent layer has Z coordinates was not doing good job and surprisingly
marking also valid geometries as invalid if layer type was PointZ but the geometry
had undefined Z value. This caused issues in IdentifyKit not picking up some features.
  • Loading branch information
wonder-sk committed Mar 28, 2019
1 parent d7f12ea commit 8b2e188
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions src/quickgui/qgsquickfeaturelayerpair.cpp
Expand Up @@ -66,8 +66,5 @@ bool QgsQuickFeatureLayerPair::hasValidGeometry() const
if ( mFeature.geometry().type() != mLayer->geometryType() )
return false;

if ( QgsWkbTypes::hasZ( mLayer->wkbType() ) != QgsWkbTypes::hasZ( mFeature.geometry().wkbType() ) )
return false;

return true;
}

0 comments on commit 8b2e188

Please sign in to comment.