[processing] Destroy widgets from an algorithm dialog as soon as it i…

…s rejected
qgis · May 17, 2020 · 8a7feed · 8a7feed
1 parent 576c2f3
commit 8a7feed
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 0 deletions.
diff --git a/python/gui/auto_generated/processing/qgsprocessingalgorithmdialogbase.sip.in b/python/gui/auto_generated/processing/qgsprocessingalgorithmdialogbase.sip.in
@@ -182,6 +182,9 @@ Copies the current log contents to the clipboard.
 Switches the dialog to the parameters page.
 %End
 
+    virtual void reject();
+
+
   protected:
 
     virtual void closeEvent( QCloseEvent *e );

diff --git a/src/gui/processing/qgsprocessingalgorithmdialogbase.cpp b/src/gui/processing/qgsprocessingalgorithmdialogbase.cpp
@@ -662,6 +662,15 @@ void QgsProcessingAlgorithmDialogBase::setInfo( const QString &message, bool isE
   processEvents();
 }
 
+void QgsProcessingAlgorithmDialogBase::reject()
+{
+  if ( !mAlgorithmTask )
+  {
+    setAttribute( Qt::WA_DeleteOnClose );
+  }
+  QDialog::reject();
+}
+
 //
 // QgsProcessingAlgorithmProgressDialog
 //

diff --git a/src/gui/processing/qgsprocessingalgorithmdialogbase.h b/src/gui/processing/qgsprocessingalgorithmdialogbase.h
@@ -230,6 +230,8 @@ class GUI_EXPORT QgsProcessingAlgorithmDialogBase : public QDialog, public QgsPr
      */
     void showParameters();
 
+    void reject() override;
+
   protected:
 
     void closeEvent( QCloseEvent *e ) override;