Renamed method addChildSettingsRegistry to appendRegistry

qgis · Apr 26, 2021 · 8a7bfa1 · 8a7bfa1
1 parent 95e7360
commit 8a7bfa1
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 8 deletions.
diff --git a/python/core/auto_generated/settings/qgssettingsregistry.sip.in b/python/core/auto_generated/settings/qgssettingsregistry.sip.in
@@ -43,9 +43,9 @@ Returns the :py:class:`QgsSettingsEntry` with the given ``key`` or None if not f
 The ``searchChildRegistries`` parameter specifies if child registries should be included in the search
 %End
 
-    void addChildSettingsRegistry( const QgsSettingsRegistry *settingsRegistry );
+    void appendRegistry( const QgsSettingsRegistry *settingsRegistry );
 %Docstring
-Add a child ``settingsRegistry`` to the register.
+Append a child ``settingsRegistry`` to the register.
 %End
 
     QList<const QgsSettingsRegistry *> getChildSettingsRegistries() const;

diff --git a/src/core/settings/qgssettingsregistry.cpp b/src/core/settings/qgssettingsregistry.cpp
@@ -81,7 +81,7 @@ const QgsSettingsEntryBase *QgsSettingsRegistry::getSettingsEntry( const QString
   return nullptr;
 }
 
-void QgsSettingsRegistry::addChildSettingsRegistry( const QgsSettingsRegistry *settingsRegistry )
+void QgsSettingsRegistry::appendRegistry( const QgsSettingsRegistry *settingsRegistry )
 {
   if ( !settingsRegistry )
   {

diff --git a/src/core/settings/qgssettingsregistry.h b/src/core/settings/qgssettingsregistry.h
@@ -58,9 +58,9 @@ class CORE_EXPORT QgsSettingsRegistry
     const QgsSettingsEntryBase *getSettingsEntry( const QString &key, bool searchChildRegistries = true ) const;
 
     /**
-     * Add a child \a settingsRegistry to the register.
+     * Append a child \a settingsRegistry to the register.
      */
-    void addChildSettingsRegistry( const QgsSettingsRegistry *settingsRegistry );
+    void appendRegistry( const QgsSettingsRegistry *settingsRegistry );
 
     /**
      * Returns the list of registered child QgsSettingsRegistry.

diff --git a/tests/src/core/testqgssettingsregistry.cpp b/tests/src/core/testqgssettingsregistry.cpp
@@ -103,8 +103,8 @@ void TestQgsSettingsRegistry::childRegistry()
 
   SettingsRegistryTest settingsRegistry;
   settingsRegistry.addSettingsEntry( &settingsEntryBool );
-  settingsRegistry.addChildSettingsRegistry( nullptr ); // should not crash
-  settingsRegistry.addChildSettingsRegistry( &settingsRegistryChild );
+  settingsRegistry.appendRegistry( nullptr ); // should not crash
+  settingsRegistry.appendRegistry( &settingsRegistryChild );
 
   // Search only in parent
   QCOMPARE( settingsRegistry.getSettingsEntry( settingsEntryIntegerKey, false ), nullptr );

diff --git a/tests/src/python/test_qgssettingsregistry.py b/tests/src/python/test_qgssettingsregistry.py
@@ -38,7 +38,7 @@ def test_settings_registry(self):
         self.assertEqual(settingsRegistry.getSettingsEntry(settingsEntry.key(), False), settingsEntry)
 
         # add registry to core registry
-        QgsApplication.settingsRegistryCore().addChildSettingsRegistry(settingsRegistry)
+        QgsApplication.settingsRegistryCore().appendRegistry(settingsRegistry)
 
         self.assertEqual(QgsApplication.settingsRegistryCore().getSettingsEntry(settingsEntry.key(), True), settingsEntry)