check for valid field index in QgsFieldFormatter::representValue

qgis · Sep 29, 2021 · 89e8d7d · 89e8d7d
1 parent 77be95f
commit 89e8d7d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/src/core/qgsfieldformatter.cpp b/src/core/qgsfieldformatter.cpp
@@ -26,6 +26,9 @@ QString QgsFieldFormatter::representValue( QgsVectorLayer *layer, int fieldIndex
   Q_UNUSED( config )
   Q_UNUSED( cache )
 
+  if ( ! layer->fields().exists( fieldIndex ) )
+    return QString();
+
   QString defVal;
   if ( layer->fields().fieldOrigin( fieldIndex ) == QgsFields::OriginProvider && layer->dataProvider() )
     defVal = layer->dataProvider()->defaultValueClause( layer->fields().fieldOriginIndex( fieldIndex ) );

diff --git a/tests/src/python/test_qgsfieldformatters.py b/tests/src/python/test_qgsfieldformatters.py
@@ -660,6 +660,8 @@ def test_representValueWithDefault(self):
                          '4')
         self.assertEqual(fieldFormatter.representValue(vl, 1, {}, None, "123"),
                          '123')
+        # bad field index
+        self.assertEqual(fieldFormatter.representValue(vl, 3, {}, None, 5), "")
 
 
 class TestQgsDateTimeFieldFormatter(unittest.TestCase):