Skip to content

Commit

Permalink
[processing] Be more tolerant, and expose map layer outputs as possible
Browse files Browse the repository at this point in the history
inputs for multi input parameters regardless of the required type

Otherwise we potentially block valid use cases. Better to be flexible
and catch errors at run time then prevent users making the model they need...
  • Loading branch information
nyalldawson committed Aug 3, 2020
1 parent 1297360 commit 88b3f43
Showing 1 changed file with 9 additions and 1 deletion.
10 changes: 9 additions & 1 deletion src/gui/processing/qgsprocessingwidgetwrapperimpl.cpp
Expand Up @@ -6296,6 +6296,7 @@ void QgsProcessingMultipleLayerPanelWidget::setModel( QgsProcessingModelAlgorith
<< QgsProcessingParameterFile::typeName(),
QStringList() << QgsProcessingOutputFile::typeName()
<< QgsProcessingOutputRasterLayer::typeName()
<< QgsProcessingOutputMapLayer::typeName()
<< QgsProcessingOutputMultipleLayers::typeName() );
break;
}
Expand All @@ -6306,6 +6307,7 @@ void QgsProcessingMultipleLayerPanelWidget::setModel( QgsProcessingModelAlgorith
<< QgsProcessingParameterMultipleLayers::typeName()
<< QgsProcessingParameterFile::typeName(),
QStringList() << QgsProcessingOutputFile::typeName()
<< QgsProcessingOutputMapLayer::typeName()
<< QgsProcessingOutputMultipleLayers::typeName() );
break;
}
Expand All @@ -6318,6 +6320,7 @@ void QgsProcessingMultipleLayerPanelWidget::setModel( QgsProcessingModelAlgorith
<< QgsProcessingParameterMultipleLayers::typeName(),
QStringList() << QgsProcessingOutputFile::typeName()
<< QgsProcessingOutputVectorLayer::typeName()
<< QgsProcessingOutputMapLayer::typeName()
<< QgsProcessingOutputMultipleLayers::typeName(),
QList< int >() << QgsProcessing::TypeVector );
break;
Expand All @@ -6331,6 +6334,7 @@ void QgsProcessingMultipleLayerPanelWidget::setModel( QgsProcessingModelAlgorith
<< QgsProcessingParameterMultipleLayers::typeName(),
QStringList() << QgsProcessingOutputFile::typeName()
<< QgsProcessingOutputVectorLayer::typeName()
<< QgsProcessingOutputMapLayer::typeName()
<< QgsProcessingOutputMultipleLayers::typeName() );
break;
}
Expand All @@ -6343,6 +6347,7 @@ void QgsProcessingMultipleLayerPanelWidget::setModel( QgsProcessingModelAlgorith
<< QgsProcessingParameterMultipleLayers::typeName(),
QStringList() << QgsProcessingOutputFile::typeName()
<< QgsProcessingOutputVectorLayer::typeName()
<< QgsProcessingOutputMapLayer::typeName()
<< QgsProcessingOutputMultipleLayers::typeName(),
QList< int >() << QgsProcessing::TypeVectorAnyGeometry << QgsProcessing::TypeVectorPoint );
break;
Expand All @@ -6356,6 +6361,7 @@ void QgsProcessingMultipleLayerPanelWidget::setModel( QgsProcessingModelAlgorith
<< QgsProcessingParameterMultipleLayers::typeName(),
QStringList() << QgsProcessingOutputFile::typeName()
<< QgsProcessingOutputVectorLayer::typeName()
<< QgsProcessingOutputMapLayer::typeName()
<< QgsProcessingOutputMultipleLayers::typeName(),
QList< int >() << QgsProcessing::TypeVectorAnyGeometry << QgsProcessing::TypeVectorLine );
break;
Expand All @@ -6369,7 +6375,8 @@ void QgsProcessingMultipleLayerPanelWidget::setModel( QgsProcessingModelAlgorith
<< QgsProcessingParameterMultipleLayers::typeName(),
QStringList() << QgsProcessingOutputFile::typeName()
<< QgsProcessingOutputVectorLayer::typeName()
<< QgsProcessingOutputMultipleLayers::typeName(),
<< QgsProcessingOutputMultipleLayers::typeName()
<< QgsProcessingOutputMapLayer::typeName(),
QList< int >() << QgsProcessing::TypeVectorAnyGeometry << QgsProcessing::TypeVectorPolygon );
break;
}
Expand All @@ -6383,6 +6390,7 @@ void QgsProcessingMultipleLayerPanelWidget::setModel( QgsProcessingModelAlgorith
<< QgsProcessingParameterFile::typeName()
<< QgsProcessingParameterMultipleLayers::typeName(),
QStringList() << QgsProcessingOutputFile::typeName()
<< QgsProcessingOutputMapLayer::typeName()
<< QgsProcessingOutputVectorLayer::typeName()
<< QgsProcessingOutputRasterLayer::typeName()
// << QgsProcessingOutputMeshLayer::typeName()
Expand Down

0 comments on commit 88b3f43

Please sign in to comment.