Fix minor Coverity issues

qgis · Jul 10, 2016 · 8828197 · 8828197
1 parent b94fbc0
commit 8828197
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 4 deletions.
diff --git a/src/core/auth/qgsauthmanager.cpp b/src/core/auth/qgsauthmanager.cpp
@@ -3351,7 +3351,7 @@ bool QgsAuthManager::authDbCommit() const
     const char* err = QT_TR_NOOP( "Auth db FAILED to rollback changes" );
     QgsDebugMsg( err );
     emit messageOut( tr( err ), authManTag(), WARNING );
-    authDbConnection().rollback();
+    ( void )authDbConnection().rollback();
     return false;
   }
 
@@ -3378,7 +3378,7 @@ bool QgsAuthManager::authDbTransactionQuery( QSqlQuery *query ) const
     const char* err = QT_TR_NOOP( "Auth db FAILED to rollback changes" );
     QgsDebugMsg( err );
     emit messageOut( tr( err ), authManTag(), WARNING );
-    authDbConnection().rollback();
+    ( void )authDbConnection().rollback();
     return false;
   }
 

diff --git a/src/core/qgsattributetableconfig.cpp b/src/core/qgsattributetableconfig.cpp
@@ -19,6 +19,7 @@
 
 QgsAttributeTableConfig::QgsAttributeTableConfig()
     : mActionWidgetStyle( DropDown )
+    , mSortOrder( Qt::AscendingOrder )
 {
 
 }

diff --git a/src/gui/attributetable/qgsattributetablemodel.cpp b/src/gui/attributetable/qgsattributetablemodel.cpp
@@ -790,7 +790,7 @@ void QgsAttributeTableModel::prefetchSortData( const QString& expressionString )
 
   if ( mSortCacheExpression.isField() )
   {
-    QString fieldName = dynamic_cast<const QgsExpression::NodeColumnRef*>( mSortCacheExpression.rootNode() )->name();
+    QString fieldName = static_cast<const QgsExpression::NodeColumnRef*>( mSortCacheExpression.rootNode() )->name();
     mSortFieldIndex = mLayerCache->layer()->fieldNameIndex( fieldName );
   }
 

diff --git a/src/providers/db2/qgsdb2provider.cpp b/src/providers/db2/qgsdb2provider.cpp
@@ -932,7 +932,11 @@ bool QgsDb2Provider::addFeatures( QgsFeatureList & flist )
       return false;
     }
   }
-  mDatabase.transaction();
+  if ( !mDatabase.transaction() )
+  {
+    QgsDebugMsg( "transaction failed" );
+    return false;
+  }
   QSqlQuery query = QSqlQuery( mDatabase );
   query.setForwardOnly( true );
   QSqlQuery queryFid = QSqlQuery( mDatabase );