Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
QgsFeatureSource/Sink can be stored in QVariant
  • Loading branch information
nyalldawson committed May 25, 2017
1 parent 4647662 commit 85d4630
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 0 deletions.
1 change: 1 addition & 0 deletions src/core/qgsfeaturesink.h
Expand Up @@ -94,5 +94,6 @@ class CORE_EXPORT QgsProxyFeatureSink : public QgsFeatureSink
QgsFeatureSink *mSink;
};

Q_DECLARE_METATYPE( QgsFeatureSink * )

#endif // QGSFEATURESINK_H
2 changes: 2 additions & 0 deletions src/core/qgsfeaturesource.h 100644 → 100755
Expand Up @@ -81,4 +81,6 @@ class CORE_EXPORT QgsFeatureSource

};

Q_DECLARE_METATYPE( QgsFeatureSource * )

#endif // QGSFEATURESOURCE_H

5 comments on commit 85d4630

@3nids
Copy link
Member

@3nids 3nids commented on 85d4630 May 29, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nyalldawson I am getting a crash when opening a 2.x project on master
here is the trace
image
does it speak to you?

@3nids
Copy link
Member

@3nids 3nids commented on 85d4630 May 29, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

another one with a master project + shapefile
image

am I the only one?

@nyalldawson
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@3nids is it related to this commit? does reverting it fix this?

@3nids
Copy link
Member

@3nids 3nids commented on 85d4630 May 29, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not investigate much. I just saw in the members that there a feature sink, and I wondered if it could be related. I'll try to dig a bit more.

@3nids
Copy link
Member

@3nids 3nids commented on 85d4630 May 29, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for the noise, cleaned and issue seems gone

Please sign in to comment.