Fix some missing context arguments in connects with lambda

nyalldawson · nyalldawson · commit 85aaf7ea82cf · 2018-11-06T10:49:34.000+10:00
These cause infinite lifetime connections which result in crashes (cherry picked from commit 3d5badf)
diff --git a/src/app/decorations/qgsdecorationnortharrowdialog.cpp b/src/app/decorations/qgsdecorationnortharrowdialog.cpp
@@ -52,7 +52,7 @@ QgsDecorationNorthArrowDialog::QgsDecorationNorthArrowDialog( QgsDecorationNorth
   spinAngle->setEnabled( !mDeco.mAutomatic );
   sliderRotation->setEnabled( !mDeco.mAutomatic );
 
-  connect( cboxAutomatic, &QAbstractButton::toggled, [ = ]( bool checked )
+  connect( cboxAutomatic, &QAbstractButton::toggled, this, [ = ]( bool checked )
   {
     spinAngle->setEnabled( !checked );
     sliderRotation->setEnabled( !checked );
diff --git a/src/app/qgsoptions.cpp b/src/app/qgsoptions.cpp
@@ -101,7 +101,7 @@ QgsOptions::QgsOptions( QWidget *parent, Qt::WindowFlags fl, const QList<QgsOpti
   connect( mCustomVariablesChkBx, &QCheckBox::toggled, this, &QgsOptions::mCustomVariablesChkBx_toggled );
   connect( mCurrentVariablesQGISChxBx, &QCheckBox::toggled, this, &QgsOptions::mCurrentVariablesQGISChxBx_toggled );
   connect( buttonBox, &QDialogButtonBox::helpRequested, this, &QgsOptions::showHelp );
-  connect( cboGlobalLocale, qgis::overload< int >::of( &QComboBox::currentIndexChanged ), [ = ]( int ) { updateSampleLocaleText( ); } );
+  connect( cboGlobalLocale, qgis::overload< int >::of( &QComboBox::currentIndexChanged ), this, [ = ]( int ) { updateSampleLocaleText( ); } );
   connect( cbShowGroupSeparator, &QCheckBox::toggled, this, [ = ]( bool ) { updateSampleLocaleText(); } );
 
   // QgsOptionsDialogBase handles saving/restoring of geometry, splitter and current tab states,
diff --git a/src/gui/processing/qgsprocessingconfigurationwidgets.cpp b/src/gui/processing/qgsprocessingconfigurationwidgets.cpp
@@ -62,7 +62,7 @@ QgsFilterAlgorithmConfigurationWidget::QgsFilterAlgorithmConfigurationWidget( QW
   connect( addOutputButton, &QToolButton::clicked, this, &QgsFilterAlgorithmConfigurationWidget::addOutput );
   connect( removeOutputButton, &QToolButton::clicked, this, &QgsFilterAlgorithmConfigurationWidget::removeSelectedOutputs );
 
-  connect( mOutputExpressionWidget->selectionModel(), &QItemSelectionModel::selectionChanged, [removeOutputButton, this]
+  connect( mOutputExpressionWidget->selectionModel(), &QItemSelectionModel::selectionChanged, this, [removeOutputButton, this]
   {
     removeOutputButton->setEnabled( !mOutputExpressionWidget->selectionModel()->selectedIndexes().isEmpty() );
   } );
diff --git a/src/plugins/georeferencer/qgsgeorefplugingui.cpp b/src/plugins/georeferencer/qgsgeorefplugingui.cpp
@@ -584,7 +584,7 @@ void QgsGeorefPluginGui::showCoordDialog( const QgsPointXY &pixelCoords )
   if ( mLayer && !mMapCoordsDialog )
   {
     mMapCoordsDialog = new QgsMapCoordsDialog( mIface->mapCanvas(), pixelCoords, this );
-    connect( mMapCoordsDialog, &QgsMapCoordsDialog::pointAdded,
+    connect( mMapCoordsDialog, &QgsMapCoordsDialog::pointAdded, this,
     [this]( const QgsPointXY & a, const QgsPointXY & b ) { this->addPoint( a, b ); }
            );
     mMapCoordsDialog->show();

Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,7 @@ QgsDecorationNorthArrowDialog::QgsDecorationNorthArrowDialog( QgsDecorationNorth`
`52`	`52`	`spinAngle->setEnabled( !mDeco.mAutomatic );`
`53`	`53`	`sliderRotation->setEnabled( !mDeco.mAutomatic );`
`54`	`54`
`55`		`- connect( cboxAutomatic, &QAbstractButton::toggled, [ = ]( bool checked )`
	`55`	`+ connect( cboxAutomatic, &QAbstractButton::toggled, this, [ = ]( bool checked )`
`56`	`56`	`{`
`57`	`57`	`spinAngle->setEnabled( !checked );`
`58`	`58`	`sliderRotation->setEnabled( !checked );`
Original file line number	Diff line number	Diff line change
`@@ -62,7 +62,7 @@ QgsFilterAlgorithmConfigurationWidget::QgsFilterAlgorithmConfigurationWidget( QW`
`62`	`62`	`connect( addOutputButton, &QToolButton::clicked, this, &QgsFilterAlgorithmConfigurationWidget::addOutput );`
`63`	`63`	`connect( removeOutputButton, &QToolButton::clicked, this, &QgsFilterAlgorithmConfigurationWidget::removeSelectedOutputs );`
`64`	`64`
`65`		`- connect( mOutputExpressionWidget->selectionModel(), &QItemSelectionModel::selectionChanged, [removeOutputButton, this]`
	`65`	`+ connect( mOutputExpressionWidget->selectionModel(), &QItemSelectionModel::selectionChanged, this, [removeOutputButton, this]`
`66`	`66`	`{`
`67`	`67`	`removeOutputButton->setEnabled( !mOutputExpressionWidget->selectionModel()->selectedIndexes().isEmpty() );`
`68`	`68`	`} );`
Original file line number	Diff line number	Diff line change
`@@ -584,7 +584,7 @@ void QgsGeorefPluginGui::showCoordDialog( const QgsPointXY &pixelCoords )`
`584`	`584`	`if ( mLayer && !mMapCoordsDialog )`
`585`	`585`	`{`
`586`	`586`	`mMapCoordsDialog = new QgsMapCoordsDialog( mIface->mapCanvas(), pixelCoords, this );`
`587`		`- connect( mMapCoordsDialog, &QgsMapCoordsDialog::pointAdded,`
	`587`	`+ connect( mMapCoordsDialog, &QgsMapCoordsDialog::pointAdded, this,`
`588`	`588`	`[this]( const QgsPointXY & a, const QgsPointXY & b ) { this->addPoint( a, b ); }`
`589`	`589`	`);`
`590`	`590`	`mMapCoordsDialog->show();`