Skip to content

Commit

Permalink
Enable disabled simplification code after merge MTR (2-2)
Browse files Browse the repository at this point in the history
Enable AntialiasingSimplification
  • Loading branch information
ahuarte47 committed May 27, 2014
1 parent 4ab24a4 commit 83eec4a
Show file tree
Hide file tree
Showing 6 changed files with 24 additions and 7 deletions.
4 changes: 4 additions & 0 deletions python/core/qgsrendercontext.sip
Expand Up @@ -72,4 +72,8 @@ class QgsRenderContext
/**Returns true if the rendering optimization (geometry simplification) can be executed*/
bool useRenderingOptimization() const;
void setUseRenderingOptimization( bool enabled );

//! Added in QGIS v2.4
const QgsVectorSimplifyMethod& vectorSimplifyMethod() const;
void setVectorSimplifyMethod( const QgsVectorSimplifyMethod& simplifyMethod );
};
2 changes: 1 addition & 1 deletion src/core/qgsrendercontext.cpp
Expand Up @@ -33,7 +33,7 @@ QgsRenderContext::QgsRenderContext()
mLabelingEngine( NULL ),
mUseRenderingOptimization( true )
{

mVectorSimplifyMethod.setSimplifyHints( QgsVectorSimplifyMethod::NoSimplification );
}

QgsRenderContext::~QgsRenderContext()
Expand Down
8 changes: 8 additions & 0 deletions src/core/qgsrendercontext.h
Expand Up @@ -23,6 +23,7 @@
#include "qgscoordinatetransform.h"
#include "qgsmaptopixel.h"
#include "qgsrectangle.h"
#include "qgsvectorsimplifymethod.h"

class QPainter;

Expand Down Expand Up @@ -104,6 +105,10 @@ class CORE_EXPORT QgsRenderContext
bool useRenderingOptimization() const { return mUseRenderingOptimization; }
void setUseRenderingOptimization( bool enabled ) { mUseRenderingOptimization = enabled; }

//! Added in QGIS v2.4
const QgsVectorSimplifyMethod& vectorSimplifyMethod() const { return mVectorSimplifyMethod; }
void setVectorSimplifyMethod( const QgsVectorSimplifyMethod& simplifyMethod ) { mVectorSimplifyMethod = simplifyMethod; }

private:

/**Painter for rendering operations*/
Expand Down Expand Up @@ -145,6 +150,9 @@ class CORE_EXPORT QgsRenderContext

/**True if the rendering optimization (geometry simplification) can be executed*/
bool mUseRenderingOptimization;

/**Simplification object which holds the information about how to simplify the features for fast rendering */
QgsVectorSimplifyMethod mVectorSimplifyMethod;
};

#endif
9 changes: 9 additions & 0 deletions src/core/qgsvectorlayerrenderer.cpp
Expand Up @@ -169,6 +169,15 @@ bool QgsVectorLayerRenderer::render()
simplifyMethod.setForceLocalOptimization( mSimplifyMethod.forceLocalOptimization() );

featureRequest.setSimplifyMethod( simplifyMethod );

QgsVectorSimplifyMethod vectorMethod = mSimplifyMethod;
mContext.setVectorSimplifyMethod( vectorMethod );
}
else
{
QgsVectorSimplifyMethod vectorMethod;
vectorMethod.setSimplifyHints( QgsVectorSimplifyMethod::NoSimplification );
mContext.setVectorSimplifyMethod( vectorMethod );
}

QgsFeatureIterator fit = mSource->getFeatures( featureRequest );
Expand Down
4 changes: 1 addition & 3 deletions src/core/symbology-ng/qgslinesymbollayerv2.cpp
Expand Up @@ -258,15 +258,13 @@ void QgsSimpleLineSymbolLayerV2::renderPolyline( const QPolygonF& points, QgsSym
p->setPen( context.selected() ? mSelPen : mPen );

// Disable 'Antialiasing' if the geometry was generalized in the current RenderContext (We known that it must have least #2 points).
#if 0 // TODO[MD]: after merge
if ( points.size() <= 2 && context.layer() && context.layer()->simplifyDrawingCanbeApplied( context.renderContext(), QgsVectorSimplifyMethod::AntialiasingSimplification ) && QgsAbstractGeometrySimplifier::canbeGeneralizedByDeviceBoundingBox( points, context.layer()->simplifyMethod().threshold() ) && ( p->renderHints() & QPainter::Antialiasing ) )
if ( points.size() <= 2 && ( context.renderContext().vectorSimplifyMethod().simplifyHints() & QgsVectorSimplifyMethod::AntialiasingSimplification ) && QgsAbstractGeometrySimplifier::canbeGeneralizedByDeviceBoundingBox( points, context.renderContext().vectorSimplifyMethod().threshold() ) && ( p->renderHints() & QPainter::Antialiasing ) )
{
p->setRenderHint( QPainter::Antialiasing, false );
p->drawPolyline( points );
p->setRenderHint( QPainter::Antialiasing, true );
return;
}
#endif

if ( offset == 0 )
{
Expand Down
4 changes: 1 addition & 3 deletions src/core/symbology-ng/qgssymbollayerv2.cpp
Expand Up @@ -427,15 +427,13 @@ void QgsFillSymbolLayerV2::_renderPolygon( QPainter* p, const QPolygonF& points,
}

// Disable 'Antialiasing' if the geometry was generalized in the current RenderContext (We known that it must have least #5 points).
#if 0 // TODO[MD]: after merge
if ( points.size() <= 5 && context.layer() && context.layer()->simplifyDrawingCanbeApplied( context.renderContext(), QgsVectorSimplifyMethod::AntialiasingSimplification ) && QgsAbstractGeometrySimplifier::canbeGeneralizedByDeviceBoundingBox( points, context.layer()->simplifyMethod().threshold() ) && ( p->renderHints() & QPainter::Antialiasing ) )
if ( points.size() <= 5 && ( context.renderContext().vectorSimplifyMethod().simplifyHints() & QgsVectorSimplifyMethod::AntialiasingSimplification ) && QgsAbstractGeometrySimplifier::canbeGeneralizedByDeviceBoundingBox( points, context.renderContext().vectorSimplifyMethod().threshold() ) && ( p->renderHints() & QPainter::Antialiasing ) )
{
p->setRenderHint( QPainter::Antialiasing, false );
p->drawRect( points.boundingRect() );
p->setRenderHint( QPainter::Antialiasing, true );
return;
}
#endif

if ( rings == NULL )
{
Expand Down

0 comments on commit 83eec4a

Please sign in to comment.