Pass list by reference

qgis · Nov 25, 2021 · 82274e8 · 82274e8
1 parent 7d54421
commit 82274e8
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/python/core/auto_generated/layertree/qgslayertreenode.sip.in b/python/core/auto_generated/layertree/qgslayertreenode.sip.in
@@ -313,7 +313,7 @@ Read common XML elements.
 Write common XML elements.
 %End
 
-    void insertChildrenPrivate( int index, QList<QgsLayerTreeNode *> nodes );
+    void insertChildrenPrivate( int index, const QList<QgsLayerTreeNode *> &nodes );
 %Docstring
 Low-level insertion of children to the node. The children must not have any parent yet!
 %End

diff --git a/src/core/layertree/qgslayertreenode.cpp b/src/core/layertree/qgslayertreenode.cpp
@@ -233,13 +233,12 @@ void QgsLayerTreeNode::writeCommonXml( QDomElement &element )
   mProperties.writeXml( element, doc );
 }
 
-void QgsLayerTreeNode::insertChildrenPrivate( int index, QList<QgsLayerTreeNode *> nodes )
+void QgsLayerTreeNode::insertChildrenPrivate( int index, const QList<QgsLayerTreeNode *> &nodes )
 {
   if ( nodes.isEmpty() )
     return;
 
-  const auto constNodes = nodes;
-  for ( QgsLayerTreeNode *node : constNodes )
+  for ( QgsLayerTreeNode *node : nodes )
   {
     Q_ASSERT( !node->mParent );
     node->mParent = this;

diff --git a/src/core/layertree/qgslayertreenode.h b/src/core/layertree/qgslayertreenode.h
@@ -285,7 +285,7 @@ class CORE_EXPORT QgsLayerTreeNode : public QObject
     void writeCommonXml( QDomElement &element );
 
     //! Low-level insertion of children to the node. The children must not have any parent yet!
-    void insertChildrenPrivate( int index, QList<QgsLayerTreeNode *> nodes );
+    void insertChildrenPrivate( int index, const QList<QgsLayerTreeNode *> &nodes );
     //! Low-level removal of children from the node.
     void removeChildrenPrivate( int from, int count, bool destroy = true );