Fix crash in server feature info due to storing incorrect reference to temporary

nyalldawson · nyalldawson · commit 82218832f48f · 2020-02-12T11:20:55.000+10:00
Seriously, auto is just plain dangerous and makes for fragile code. Let's all just stop using it PLEASE? (cherry picked from commit b3f37fd)
diff --git a/src/server/services/wms/qgswmsrenderer.cpp b/src/server/services/wms/qgswmsrenderer.cpp
@@ -1262,13 +1262,13 @@ namespace QgsWms
         if ( ! mContext.parameters().queryLayersNickname().contains( queryLayer ) )
         {
           // Find which group this layer belongs to
-          const auto &constNicks { mContext.parameters().queryLayersNickname() };
-          for ( const auto &ql : constNicks )
+          const QStringList constNicks { mContext.parameters().queryLayersNickname() };
+          for ( const QString &ql : constNicks )
           {
             if ( mContext.layerGroups().contains( ql ) )
             {
-              const auto &constLayers { mContext.layerGroups()[ql] };
-              for ( const auto &ml : constLayers )
+              const QList<QgsMapLayer *> constLayers { mContext.layerGroups()[ql] };
+              for ( const QgsMapLayer *ml : constLayers )
               {
                 if ( ( ! ml->shortName().isEmpty() &&  ml->shortName() == queryLayer ) || ( ml->name() == queryLayer ) )
                 {

Original file line number	Diff line number	Diff line change
`@@ -1262,13 +1262,13 @@ namespace QgsWms`
`1262`	`1262`	`if ( ! mContext.parameters().queryLayersNickname().contains( queryLayer ) )`
`1263`	`1263`	`{`
`1264`	`1264`	`// Find which group this layer belongs to`
`1265`		`- const auto &constNicks { mContext.parameters().queryLayersNickname() };`
`1266`		`- for ( const auto &ql : constNicks )`
	`1265`	`+ const QStringList constNicks { mContext.parameters().queryLayersNickname() };`
	`1266`	`+ for ( const QString &ql : constNicks )`
`1267`	`1267`	`{`
`1268`	`1268`	`if ( mContext.layerGroups().contains( ql ) )`
`1269`	`1269`	`{`
`1270`		`- const auto &constLayers { mContext.layerGroups()[ql] };`
`1271`		`- for ( const auto &ml : constLayers )`
	`1270`	`+ const QList<QgsMapLayer *> constLayers { mContext.layerGroups()[ql] };`
	`1271`	`+ for ( const QgsMapLayer *ml : constLayers )`
`1272`	`1272`	`{`
`1273`	`1273`	`if ( ( ! ml->shortName().isEmpty() && ml->shortName() == queryLayer ) \|\| ( ml->name() == queryLayer ) )`
`1274`	`1274`	`{`