UX - Review tooltip about dimensions in QGIS server dialog

qgis · Feb 13, 2022 · 80e845d · 80e845d
1 parent a673230
commit 80e845d
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 3 deletions.
diff --git a/src/gui/vector/qgswmsdimensiondialog.cpp b/src/gui/vector/qgswmsdimensiondialog.cpp
@@ -33,6 +33,10 @@ QgsWmsDimensionDialog::QgsWmsDimensionDialog( QgsVectorLayer *layer, QStringList
     return;
   }
 
+  const QString nameToolTip = tr( "OAPIF supports \"Name\" and \"Date\" only. For \"WMS\", \"Time\" and \"Elevation\" are predefined values according to OGC specifications but it can be user-defined." );
+  mNameLabel->setToolTip( nameToolTip );
+  mNameComboBox->setToolTip( nameToolTip );
+
   // Set field combobox
   mFieldComboBox->setLayer( mLayer );
   mEndFieldComboBox->setLayer( mLayer );
@@ -68,6 +72,8 @@ QgsWmsDimensionDialog::QgsWmsDimensionDialog( QgsVectorLayer *layer, QStringList
 
   mReferenceValueLabel->setEnabled( false );
   mReferenceValueComboBox->setEnabled( false );
+
+  fieldChanged();
 }
 
 void QgsWmsDimensionDialog::setInfo( const QgsMapLayerServerProperties::WmsDimensionInfo &info )
@@ -140,6 +146,10 @@ void QgsWmsDimensionDialog::nameChanged( const QString &name )
   mUnitSymbolLabel->setEnabled( true );
   mUnitSymbolLineEdit->setEnabled( true );
   mUnitSymbolLineEdit->clear();
+  mFieldLabel->setToolTip( QString() );
+  mEndFieldLabel->setToolTip( QString() );
+  mFieldComboBox->setToolTip( QString() );
+  mEndFieldComboBox->setToolTip( QString() );
 
   // Is the name a predefined value?
   if ( mNameComboBox->findText( name ) != -1 )
@@ -159,6 +169,12 @@ void QgsWmsDimensionDialog::nameChanged( const QString &name )
       mUnitsLineEdit->setEnabled( false );
       mUnitSymbolLabel->setEnabled( false );
       mUnitSymbolLineEdit->setEnabled( false );
+
+      const QString fieldToolTip = tr( "If a string is used, it must be formatted according to <a href=\"https://www.iso.org/iso-8601-date-and-time-format.html\">ISO8601</a>." );
+      mFieldLabel->setToolTip( fieldToolTip );
+      mEndFieldLabel->setToolTip( fieldToolTip );
+      mFieldComboBox->setToolTip( fieldToolTip );
+      mEndFieldComboBox->setToolTip( fieldToolTip );
     }
     if ( data == QgsMapLayerServerProperties::DATE )
     {

diff --git a/src/ui/qgswmsdimensiondialogbase.ui b/src/ui/qgswmsdimensiondialogbase.ui
@@ -11,7 +11,7 @@
    </rect>
   </property>
   <property name="windowTitle">
-   <string>Add WMS Dimension</string>
+   <string>Add WMS/OAPIF Dimension</string>
   </property>
   <layout class="QGridLayout" name="gridLayout">
    <item row="4" column="1">
@@ -53,15 +53,15 @@
    <item row="0" column="0">
     <widget class="QLabel" name="mNameLabel">
      <property name="toolTip">
-      <string>OAPIF supports &quot;Name&quot; and &quot;Date&quot; only, &quot;WMS&quot; does not support &quot;Date&quot;</string>
+      <string/>
      </property>
      <property name="text">
       <string>Name</string>
      </property>
     </widget>
    </item>
    <item row="2" column="0">
-    <widget class="QLabel" name="mEndFiledLabel">
+    <widget class="QLabel" name="mEndFieldLabel">
      <property name="text">
       <string>End attribute (optional)</string>
      </property>