Avoid recursive changeGeometry

m-kuhn · m-kuhn · commit 8085200330bb · 2018-10-15T14:28:06.000+02:00
diff --git a/src/analysis/vector/geometry_checker/qgsvectorlayerfeaturepool.cpp b/src/analysis/vector/geometry_checker/qgsvectorlayerfeaturepool.cpp
@@ -135,12 +135,13 @@ void QgsVectorLayerFeaturePool::deleteFeature( QgsFeatureId fid )
 
 void QgsVectorLayerFeaturePool::onGeometryChanged( QgsFeatureId fid, const QgsGeometry &geometry )
 {
+  Q_UNUSED( geometry )
+
   if ( isFeatureCached( fid ) )
   {
     QgsFeature feature;
     getFeature( fid, feature );
-    feature.setGeometry( geometry );
-    updateFeature( feature );
+    refreshCache( feature );
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -135,12 +135,13 @@ void QgsVectorLayerFeaturePool::deleteFeature( QgsFeatureId fid )`
`135`	`135`
`136`	`136`	`void QgsVectorLayerFeaturePool::onGeometryChanged( QgsFeatureId fid, const QgsGeometry &geometry )`
`137`	`137`	`{`
	`138`	`+ Q_UNUSED( geometry )`
	`139`	`+`
`138`	`140`	`if ( isFeatureCached( fid ) )`
`139`	`141`	`{`
`140`	`142`	`QgsFeature feature;`
`141`	`143`	`getFeature( fid, feature );`
`142`		`- feature.setGeometry( geometry );`
`143`		`- updateFeature( feature );`
	`144`	`+ refreshCache( feature );`
`144`	`145`	`}`
`145`	`146`	`}`
`146`	`147`