[BUGFIX][QGIS Server] Do not cache invalid layer

rldhont · rldhont · commit 80827625dfa9 · 2016-10-25T13:53:16.000+02:00
After readLayerXml, the server stored layers in cache and in registry without verifying validity.
diff --git a/src/server/qgshostedrdsbuilder.cpp b/src/server/qgshostedrdsbuilder.cpp
@@ -62,7 +62,7 @@ QgsMapLayer* QgsHostedRDSBuilder::createMapLayer( const QDomElement& elem,
     {
       rl = qobject_cast<QgsRasterLayer*>( QgsMSLayerCache::instance()->searchLayer( uri, layerName ) );
     }
-    if ( !rl )
+    if ( !rl || !rl->isValid() )
     {
       QgsDebugMsg( "hostedrds layer not in cache, so create and insert it" );
       rl = new QgsRasterLayer( uri, layerNameFromUri( uri ) );
diff --git a/src/server/qgsserverprojectparser.cpp b/src/server/qgsserverprojectparser.cpp
@@ -278,6 +278,10 @@ QgsMapLayer* QgsServerProjectParser::createLayerFromElement( const QDomElement&
     layer->readLayerXML( const_cast<QDomElement&>( elem ) ); //should be changed to const in QgsMapLayer
     //layer->setLayerName( layerName( elem ) );
 
+    if ( !layer->isValid() )
+    {
+      return nullptr;
+    }
     // Insert layer in registry and cache before addValueRelationLayersForLayer
     if ( !QgsMapLayerRegistry::instance()->mapLayer( id ) )
       QgsMapLayerRegistry::instance()->addMapLayer( layer, false, false );

Original file line number	Diff line number	Diff line change
`@@ -62,7 +62,7 @@ QgsMapLayer* QgsHostedRDSBuilder::createMapLayer( const QDomElement& elem,`
`62`	`62`	`{`
`63`	`63`	`rl = qobject_cast<QgsRasterLayer*>( QgsMSLayerCache::instance()->searchLayer( uri, layerName ) );`
`64`	`64`	`}`
`65`		`- if ( !rl )`
	`65`	`+ if ( !rl \|\| !rl->isValid() )`
`66`	`66`	`{`
`67`	`67`	`QgsDebugMsg( "hostedrds layer not in cache, so create and insert it" );`
`68`	`68`	`rl = new QgsRasterLayer( uri, layerNameFromUri( uri ) );`