Use QgsDebugMsg instead of QgsMessageLog for non-error feedback

nyalldawson · nyalldawson · commit 80148c983bfd · 2017-09-13T05:47:20.000+10:00
QgsMessageLog should only be used for errors or warnings,
not 'everything is working ok' type debug messages
diff --git a/src/gui/geonode/qgsgeonodesourceselect.cpp b/src/gui/geonode/qgsgeonodesourceselect.cpp
@@ -199,7 +199,7 @@ void QgsGeoNodeSourceSelect::connectToGeonodeConnection()
 
   if ( !layers.empty() )
   {
-    QgsMessageLog::logMessage( QStringLiteral( "Success, non empty layers %1" ).arg( layers.count( ) ), tr( "GeoNode" ) );
+    QgsDebugMsg( QStringLiteral( "Success, non empty layers %1" ).arg( layers.count( ) ) );
   }
   else
   {
@@ -479,7 +479,7 @@ void QgsGeoNodeSourceSelect::addButtonClicked()
       uri += QStringLiteral( " table=\"\"" );
       uri += QStringLiteral( " sql=" );
 
-      QgsMessageLog::logMessage( "Add WFS from GeoNode : " + uri + " and typename: " + typeName, tr( "GeoNode" ) );
+      QgsDebugMsg( "Add WFS from GeoNode : " + uri + " and typename: " + typeName );
       emit addWfsLayer( uri, typeName, "WFS" );
     }
     else if ( webServiceType == "XYZ" )

Original file line number	Diff line number	Diff line change
`@@ -199,7 +199,7 @@ void QgsGeoNodeSourceSelect::connectToGeonodeConnection()`
`199`	`199`
`200`	`200`	`if ( !layers.empty() )`
`201`	`201`	`{`
`202`		`- QgsMessageLog::logMessage( QStringLiteral( "Success, non empty layers %1" ).arg( layers.count( ) ), tr( "GeoNode" ) );`
	`202`	`+ QgsDebugMsg( QStringLiteral( "Success, non empty layers %1" ).arg( layers.count( ) ) );`
`203`	`203`	`}`
`204`	`204`	`else`
`205`	`205`	`{`
`@@ -479,7 +479,7 @@ void QgsGeoNodeSourceSelect::addButtonClicked()`
`479`	`479`	`uri += QStringLiteral( " table=\"\"" );`
`480`	`480`	`uri += QStringLiteral( " sql=" );`
`481`	`481`
`482`		`- QgsMessageLog::logMessage( "Add WFS from GeoNode : " + uri + " and typename: " + typeName, tr( "GeoNode" ) );`
	`482`	`+ QgsDebugMsg( "Add WFS from GeoNode : " + uri + " and typename: " + typeName );`
`483`	`483`	`emit addWfsLayer( uri, typeName, "WFS" );`
`484`	`484`	`}`
`485`	`485`	`else if ( webServiceType == "XYZ" )`