Skip to content

Commit

Permalink
fix windows build and some warnings
Browse files Browse the repository at this point in the history
  • Loading branch information
jef-n committed Jan 7, 2012
1 parent cb1eb2a commit 7f7f61e
Show file tree
Hide file tree
Showing 6 changed files with 19 additions and 16 deletions.
22 changes: 11 additions & 11 deletions src/core/qgsexpression.h
Expand Up @@ -210,7 +210,7 @@ class CORE_EXPORT QgsExpression

class Visitor; // visitor interface is defined below

class Node
class CORE_EXPORT Node
{
public:
virtual ~Node() {}
Expand All @@ -231,7 +231,7 @@ class CORE_EXPORT QgsExpression
virtual void accept( Visitor& v ) = 0;
};

class NodeList
class CORE_EXPORT NodeList
{
public:
NodeList() {}
Expand All @@ -245,7 +245,7 @@ class CORE_EXPORT QgsExpression
QList<Node*> mList;
};

class NodeUnaryOperator : public Node
class CORE_EXPORT NodeUnaryOperator : public Node
{
public:
NodeUnaryOperator( UnaryOperator op, Node* operand ) : mOp( op ), mOperand( operand ) {}
Expand All @@ -266,7 +266,7 @@ class CORE_EXPORT QgsExpression
Node* mOperand;
};

class NodeBinaryOperator : public Node
class CORE_EXPORT NodeBinaryOperator : public Node
{
public:
NodeBinaryOperator( BinaryOperator op, Node* opLeft, Node* opRight ) : mOp( op ), mOpLeft( opLeft ), mOpRight( opRight ) {}
Expand All @@ -293,7 +293,7 @@ class CORE_EXPORT QgsExpression
Node* mOpRight;
};

class NodeInOperator : public Node
class CORE_EXPORT NodeInOperator : public Node
{
public:
NodeInOperator( Node* node, NodeList* list, bool notin = false ) : mNode( node ), mList( list ), mNotIn( notin ) {}
Expand All @@ -316,7 +316,7 @@ class CORE_EXPORT QgsExpression
bool mNotIn;
};

class NodeFunction : public Node
class CORE_EXPORT NodeFunction : public Node
{
public:
NodeFunction( int fnIndex, NodeList* args ): mFnIndex( fnIndex ), mArgs( args ) {}
Expand All @@ -339,7 +339,7 @@ class CORE_EXPORT QgsExpression
NodeList* mArgs;
};

class NodeLiteral : public Node
class CORE_EXPORT NodeLiteral : public Node
{
public:
NodeLiteral( QVariant value ) : mValue( value ) {}
Expand All @@ -357,7 +357,7 @@ class CORE_EXPORT QgsExpression
QVariant mValue;
};

class NodeColumnRef : public Node
class CORE_EXPORT NodeColumnRef : public Node
{
public:
NodeColumnRef( QString name ) : mName( name ), mIndex( -1 ) {}
Expand All @@ -376,7 +376,7 @@ class CORE_EXPORT QgsExpression
int mIndex;
};

class WhenThen
class CORE_EXPORT WhenThen
{
public:
WhenThen( Node* whenExp, Node* thenExp ) : mWhenExp( whenExp ), mThenExp( thenExp ) {}
Expand All @@ -388,7 +388,7 @@ class CORE_EXPORT QgsExpression
};
typedef QList<WhenThen*> WhenThenList;

class NodeCondition : public Node
class CORE_EXPORT NodeCondition : public Node
{
public:
NodeCondition( WhenThenList* conditions, Node* elseExp = NULL ) : mConditions( *conditions ), mElseExp( elseExp ) { delete conditions; }
Expand All @@ -410,7 +410,7 @@ class CORE_EXPORT QgsExpression

/** support for visitor pattern - algorithms dealing with the expressions
may be implemented without modifying the Node classes */
class Visitor
class CORE_EXPORT Visitor
{
public:
virtual ~Visitor() {}
Expand Down
5 changes: 4 additions & 1 deletion src/providers/wfs/qgswfsprovider.cpp
Expand Up @@ -2355,7 +2355,10 @@ void QgsWFSProvider::appendSupportedOperations( const QDomElement& operationsEle
//initialization for getRenderedOnly option
//(formerly "Only request features overlapping the current view extent")
bool QgsWFSProvider::initGetRenderedOnly( const QgsRectangle rect )
{ //find our layer
{
Q_UNUSED( rect );

//find our layer
QMap<QString, QgsMapLayer*> layers = QgsMapLayerRegistry::instance()->mapLayers();
QMap<QString, QgsMapLayer*>::const_iterator layersIt = layers.begin();
for ( ; layersIt != layers.end() ; ++layersIt )
Expand Down
2 changes: 1 addition & 1 deletion src/providers/wfs/qgswfsutils.cpp
Expand Up @@ -91,7 +91,7 @@ class QgsExpressionOGCVisitor : public QgsExpression::Visitor
mResult = true;
}

void visit( QgsExpression::NodeCondition* n ) { mResult = false; }
void visit( QgsExpression::NodeCondition* n ) { Q_UNUSED( n ); mResult = false; }

protected:
QDomDocument mDoc;
Expand Down
2 changes: 1 addition & 1 deletion src/ui/qgsoptionsbase.ui
Expand Up @@ -521,7 +521,7 @@
<attribute name="title">
<string>GDAL</string>
</attribute>
<layout class="QGridLayout" name="gridLayout">
<layout class="QGridLayout" name="gridLayout_27">
<item row="0" column="0">
<widget class="QGroupBox" name="groupBox_13">
<property name="title">
Expand Down
2 changes: 1 addition & 1 deletion src/ui/qgsprojectpropertiesbase.ui
Expand Up @@ -382,7 +382,7 @@
<height>538</height>
</rect>
</property>
<layout class="QGridLayout" name="gridLayout">
<layout class="QGridLayout" name="gridLayout_7">
<item row="0" column="0" colspan="2">
<widget class="QGroupBox" name="grpWMSServiceCapabilities">
<property name="title">
Expand Down
2 changes: 1 addition & 1 deletion src/ui/qgsvectorlayerpropertiesbase.ui
Expand Up @@ -548,7 +548,7 @@
<attribute name="title">
<string>Metadata</string>
</attribute>
<layout class="QGridLayout" name="gridLayout">
<layout class="QGridLayout" name="gridLayout_15">
<item row="0" column="0">
<widget class="QLabel" name="mLayerTitleLabel">
<property name="text">
Expand Down

0 comments on commit 7f7f61e

Please sign in to comment.