Unit tests for encodeUri/decodeUri for GPX

qgis · Jul 31, 2021 · 7e66281 · 7e66281
1 parent 99c7fdf
commit 7e66281
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 2 deletions.
diff --git a/src/providers/gpx/qgsgpxprovider.cpp b/src/providers/gpx/qgsgpxprovider.cpp
@@ -548,7 +548,7 @@ QVariantMap QgsGPXProvider::decodeUri( const QString &uri )
     res.insert( QStringLiteral( "layerName" ), uri.mid( fileNameEnd + 6 ) );
     res.insert( QStringLiteral( "path" ), uri.left( fileNameEnd ) );
   }
-  else
+  else if ( !uri.isEmpty() )
   {
     res.insert( QStringLiteral( "path" ), uri );
   }

diff --git a/tests/src/python/test_provider_gpx.py b/tests/src/python/test_provider_gpx.py
@@ -13,7 +13,8 @@
 from qgis.core import (
     QgsVectorLayer,
     QgsFeature,
-    QgsPoint
+    QgsPoint,
+    QgsProviderRegistry
 )
 from qgis.testing import (
     start_app,
@@ -177,6 +178,27 @@ def test_invalid_source(self):
 
         self.assertFalse(vl.dataProvider().changeAttributeValues({1: {1: 'a'}}))
 
+    def test_encode_decode_uri(self):
+        metadata = QgsProviderRegistry.instance().providerMetadata('gpx')
+        self.assertIsNotNone(metadata)
+
+        self.assertEqual(metadata.encodeUri({}), '')
+        self.assertEqual(metadata.decodeUri(''), {})
+        self.assertEqual(metadata.encodeUri({'path': '/home/me/test.gpx'}), '/home/me/test.gpx')
+        self.assertEqual(metadata.decodeUri('/home/me/test.gpx'), {'path': '/home/me/test.gpx'})
+        self.assertEqual(metadata.encodeUri({'path': '/home/me/test.gpx',
+                                             'layerName': 'waypoints'}), '/home/me/test.gpx?type=waypoints')
+        self.assertEqual(metadata.decodeUri('/home/me/test.gpx?type=waypoints'), {'path': '/home/me/test.gpx',
+                                                                                  'layerName': 'waypoints'})
+        self.assertEqual(metadata.encodeUri({'path': '/home/me/test.gpx',
+                                             'layerName': 'tracks'}), '/home/me/test.gpx?type=tracks')
+        self.assertEqual(metadata.decodeUri('/home/me/test.gpx?type=tracks'), {'path': '/home/me/test.gpx',
+                                                                               'layerName': 'tracks'})
+        self.assertEqual(metadata.encodeUri({'path': '/home/me/test.gpx',
+                                             'layerName': 'routes'}), '/home/me/test.gpx?type=routes')
+        self.assertEqual(metadata.decodeUri('/home/me/test.gpx?type=routes'), {'path': '/home/me/test.gpx',
+                                                                               'layerName': 'routes'})
+
 
 if __name__ == '__main__':
     unittest.main()