Skip to content

Commit 7e4345a

Browse files
jef-njef-n
committedAug 20, 2017
remove sip workaround (fixes #17038, refs #16071)
·
final-2_18_28final-2_18_13
1 parent 9018414 commit 7e4345a

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed
 

‎python/core/qgscoordinatetransform.sip

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
class QgsCoordinateTransform : QObject
1616
{
1717
%TypeHeaderCode
18-
extern PyObject *sipExportedExceptions__core[2]; // workaround: sipExportedExceptions__core is only defined in the first sip part
1918
#include <qgscoordinatetransform.h>
2019
%End
2120

7 commit comments

Comments
 (7)

3nids commented on Aug 22, 2017

@3nids
3nids
on Aug 22, 2017
Member

getting an error here
image
I did clean without success...

3nids commented on Aug 22, 2017

@3nids
3nids
on Aug 22, 2017
Member

reverting this allows me to compile....any idea @jef-n ?

jef-n commented on Aug 22, 2017

@jef-n
jef-n
on Aug 22, 2017
MemberAuthor

upgrade sip? which version are you using?

3nids commented on Aug 22, 2017

@3nids
3nids
on Aug 22, 2017
Member

4.19.1

jef-n commented on Aug 22, 2017

@jef-n
jef-n
on Aug 22, 2017
MemberAuthor

FTR the ticket is https://issues.qgis.org/issues/17039

jef-n commented on Aug 22, 2017

@jef-n
jef-n
on Aug 22, 2017
MemberAuthor

Does that help for you?

diff --git a/python/core/qgscoordinatetransform.sip b/python/core/qgscoordinatetransform.sip
index f9b7854c32..900967d37f 100644
--- a/python/core/qgscoordinatetransform.sip
+++ b/python/core/qgscoordinatetransform.sip
@@ -15,7 +15,9 @@
 class QgsCoordinateTransform : QObject
 {
 %TypeHeaderCode
+#if (SIP_VERSION >= 0x041300 && SIP_VERSION < 0x041303)
 extern PyObject *sipExportedExceptions__core[2];  // workaround: sipExportedExceptions__core is only defined in the first sip part
+#endif
 #include <qgscoordinatetransform.h>
 %End

Not sure whether 4.19.2 is also affected though...

3nids commented on Aug 22, 2017

@3nids
3nids
on Aug 22, 2017
Member

yep, it does the trick!

Please sign in to comment.