Remove all previously autoconnected slots from public API

These are implementation details only, and should not be part of the stable API. We need the flexibility to change these at any stage without being bound by any API contract.
qgis · Oct 8, 2017 · 7cfd284 · 7cfd284
1 parent 1429f2c
commit 7cfd284
Show file tree

Hide file tree

Showing 22 changed files with 137 additions and 331 deletions.
diff --git a/python/gui/qgserrordialog.sip b/python/gui/qgserrordialog.sip
@@ -31,10 +31,6 @@ class QgsErrorDialog: QDialog
  \param fl widget flags
 %End
 
-  public slots:
-    void mDetailPushButton_clicked();
-    void mDetailCheckBox_stateChanged( int state );
-
 };
 
 /************************************************************************

diff --git a/python/gui/qgsnewvectorlayerdialog.sip b/python/gui/qgsnewvectorlayerdialog.sip
@@ -60,19 +60,6 @@ Returns the file format for storage
 .. seealso:: crs()
 %End
 
-  protected slots:
-    void mAddAttributeButton_clicked();
-    void mRemoveAttributeButton_clicked();
-    void mFileFormatComboBox_currentIndexChanged( int index );
-    void mTypeBox_currentIndexChanged( int index );
-
-    void showHelp();
-%Docstring
-Open the associated help
-%End
-    void nameChanged( const QString & );
-    void selectionChanged();
-
 };
 
 /************************************************************************

diff --git a/python/gui/qgsowssourceselect.sip b/python/gui/qgsowssourceselect.sip
@@ -48,63 +48,15 @@ Constructor
 Triggered when the provider's connections need to be refreshed
 %End
 
-    void mNewButton_clicked();
-%Docstring
-Opens the create connection dialog to build a new connection
-%End
-    void mEditButton_clicked();
-%Docstring
-Opens a dialog to edit an existing connection
-%End
-    void mDeleteButton_clicked();
-%Docstring
-Deletes the selected connection
-%End
-    void mSaveButton_clicked();
-%Docstring
-Saves connections to the file
-%End
-    void mLoadButton_clicked();
-%Docstring
-Loads connections from the file
-%End
-
-    void mConnectButton_clicked();
-%Docstring
- Connects to the database using the stored connection parameters.
- Once connected, available layers are displayed.
-%End
-
-    void searchFinished();
-
-    void mChangeCRSButton_clicked();
-%Docstring
-Opens the Spatial Reference System dialog.
-%End
-
-    virtual void mLayersTreeWidget_itemSelectionChanged();
-%Docstring
-Signaled when a layer selection is changed.
-%End
-
-    void showStatusMessage( const QString &message );
-%Docstring
-Set status message to theMessage
-%End
-
+  protected slots:
     void showError( const QString &title, const QString &format, const QString &error );
 %Docstring
 show whatever error is exposed.
 %End
 
-    void mConnectionsComboBox_activated( int );
-%Docstring
-Stores the selected datasource whenerver it is changed
-%End
-
-    void mAddDefaultButton_clicked();
+    void showStatusMessage( const QString &message );
 %Docstring
-Add some default wms servers to the list
+Set status message to theMessage
 %End
 
   protected:
@@ -245,7 +197,6 @@ Returns currently selected cache load control
 
 
 
-
 };
 
 /************************************************************************

diff --git a/python/gui/qgsquerybuilder.sip b/python/gui/qgsquerybuilder.sip
@@ -39,34 +39,18 @@ class QgsQueryBuilder : QDialog
     virtual void showEvent( QShowEvent *event );
 
 
+    QString sql();
+%Docstring
+ :rtype: str
+%End
+    void setSql( const QString &sqlStatement );
+
   public slots:
     virtual void accept();
 
     virtual void reject();
 
     void clear();
-    void btnEqual_clicked();
-    void btnLessThan_clicked();
-    void btnGreaterThan_clicked();
-    void btnPct_clicked();
-    void btnIn_clicked();
-    void btnNotIn_clicked();
-    void btnLike_clicked();
-    void btnILike_clicked();
-    QString sql();
-%Docstring
- :rtype: str
-%End
-    void setSql( const QString &sqlStatement );
-    void lstFields_clicked( const QModelIndex &index );
-    void lstFields_doubleClicked( const QModelIndex &index );
-    void lstValues_doubleClicked( const QModelIndex &index );
-    void btnLessEqual_clicked();
-    void btnGreaterEqual_clicked();
-    void btnNotEqual_clicked();
-    void btnAnd_clicked();
-    void btnNot_clicked();
-    void btnOr_clicked();
 
     void test();
 %Docstring
@@ -76,19 +60,6 @@ class QgsQueryBuilder : QDialog
  statement.
 %End
 
-    void btnGetAllValues_clicked();
-%Docstring
- Get all distinct values for the field. Values are inserted
- into the value list box
-%End
-
-    void btnSampleValues_clicked();
-%Docstring
- Get sample distinct values for the selected field. The sample size is
- limited to an arbitrary value (currently set to 25). The values
- are inserted into the values list box.
-%End
-
     void setDatasourceDescription( const QString &uri );
 
 };

diff --git a/python/gui/qgssearchquerybuilder.sip b/python/gui/qgssearchquerybuilder.sip
@@ -39,44 +39,6 @@ change search string shown in text field
 %End
 
   public slots:
-    void btnEqual_clicked();
-    void on_btnOk_clicked();
-    void btnLessThan_clicked();
-    void btnGreaterThan_clicked();
-    void btnLike_clicked();
-    void btnILike_clicked();
-    void btnPct_clicked();
-    void btnIn_clicked();
-    void btnNotIn_clicked();
-
-    void lstFields_doubleClicked( const QModelIndex &index );
-    void lstValues_doubleClicked( const QModelIndex &index );
-    void btnLessEqual_clicked();
-    void btnGreaterEqual_clicked();
-    void btnNotEqual_clicked();
-    void btnAnd_clicked();
-    void btnNot_clicked();
-    void btnOr_clicked();
-    void btnClear_clicked();
-
-    void btnTest_clicked();
-%Docstring
- Test the constructed search string to see if it's correct.
- The number of rows that would be returned is displayed in a message box.
-%End
-
-    void btnGetAllValues_clicked();
-%Docstring
- Get all distinct values for the field. Values are inserted
- into the value list box
-%End
-
-    void btnSampleValues_clicked();
-%Docstring
- Get sample distinct values for the selected field. The sample size is
- limited to an arbitrary value (currently set to 25). The values
- are inserted into the values list box.
-%End
 
     void saveQuery();
     void loadQuery();

diff --git a/python/gui/raster/qgsrasterhistogramwidget.sip b/python/gui/raster/qgsrasterhistogramwidget.sip
@@ -60,10 +60,6 @@ Apply a histoActionTriggered() event.
     void refreshHistogram();
 %Docstring
  slot executed when user wishes to refresh raster histogramwidget
-%End
-    void mSaveAsImageButton_clicked();
-%Docstring
-This slot lets you save the histogram as an image to disk
 %End
 
     virtual void apply();

diff --git a/python/gui/symbology/qgsgraduatedsymbolrendererwidget.sip b/python/gui/symbology/qgsgraduatedsymbolrendererwidget.sip
@@ -60,8 +60,6 @@ Toggle the link between classes boundaries
 
     void rowsMoved();
     void modelDataChanged();
-    void mSizeUnitWidget_changed();
-    void methodComboBox_currentIndexChanged( int );
     void refreshRanges( bool reset = false );
 
   protected:

diff --git a/python/gui/symbology/qgssmartgroupeditordialog.sip b/python/gui/symbology/qgssmartgroupeditordialog.sip
@@ -103,9 +103,8 @@ function to create a new ConditionBox and update UI
 slot to remove the condition with id int
 %End
 
-    void buttonBox_accepted();
-
   protected:
+
 };
 
 /************************************************************************

diff --git a/python/gui/symbology/qgsstylemanagerdialog.sip b/python/gui/symbology/qgsstylemanagerdialog.sip
@@ -36,7 +36,6 @@ open add color ramp dialog, return color ramp's name if the ramp has been added
     void exportItems();
     void importItems();
 
-    void tabItemType_currentChanged( int );
     void populateList();
 %Docstring
 adds symbols of some type to list
@@ -228,6 +227,7 @@ sets the text of the item with bold font
 
 
 
+
 };
 
 /************************************************************************