extentsChanged deprecated as reloadVisible (private)

qgis · Mar 18, 2020 · 7c54194 · 7c54194
1 parent 8562f78
commit 7c54194
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 6 deletions.
diff --git a/python/gui/auto_generated/attributetable/qgsattributetablefiltermodel.sip.in b/python/gui/auto_generated/attributetable/qgsattributetablefiltermodel.sip.in
@@ -242,11 +242,13 @@ selection state of the feature in case selected features are to be shown on top.
 
   public slots:
 
-    void reloadVisible();
+ void extentsChanged();
 %Docstring
-Is called upon every change of the visible extents on the map canvas or when data of
-the master table model change.
+Is called upon every change of the visible extents on the map canvas.
 When a change is signalled, the filter is updated and invalidated if needed.
+
+.. deprecated:: QGIS 3.10.3
+   - made private as reloadVisible()
 %End
 
     void filterFeatures();

diff --git a/src/gui/attributetable/qgsattributetablefiltermodel.cpp b/src/gui/attributetable/qgsattributetablefiltermodel.cpp
@@ -389,6 +389,11 @@ bool QgsAttributeTableFilterModel::filterAcceptsRow( int sourceRow, const QModel
   // returns are handled in their respective case statement above
 }
 
+void QgsAttributeTableFilterModel::extentsChanged()
+{
+  reloadVisible();
+}
+
 void QgsAttributeTableFilterModel::reloadVisible()
 {
   generateListOfVisibleFeatures();

diff --git a/src/gui/attributetable/qgsattributetablefiltermodel.h b/src/gui/attributetable/qgsattributetablefiltermodel.h
@@ -263,11 +263,12 @@ class GUI_EXPORT QgsAttributeTableFilterModel: public QSortFilterProxyModel, pub
   public slots:
 
     /**
-     * Is called upon every change of the visible extents on the map canvas or when data of
-     * the master table model change.
+     * Is called upon every change of the visible extents on the map canvas.
      * When a change is signalled, the filter is updated and invalidated if needed.
+     *
+     * \deprecated since QGIS 3.10.3 - made private as reloadVisible()
      */
-    void reloadVisible();
+    Q_DECL_DEPRECATED void extentsChanged();
 
     /**
      * Updates the filtered features in the filter model. It is called when the data of the
@@ -280,6 +281,7 @@ class GUI_EXPORT QgsAttributeTableFilterModel: public QSortFilterProxyModel, pub
   private slots:
     void selectionChanged();
     void onColumnsChanged();
+    void reloadVisible();
 
   private:
     QgsFeatureIds mFilteredFeatures;