Fix some coverity uninitialized variable warnings

nyalldawson · nyalldawson · commit 7b14373a8e32 · 2017-01-27T09:55:12.000+10:00
diff --git a/src/app/dwg/qgsdwgimporter.cpp b/src/app/dwg/qgsdwgimporter.cpp
@@ -1471,7 +1471,7 @@ void QgsDwgImporter::addLWPolyline( const DRW_LWPolyline &data )
 
   QgsPointSequence s;
   QgsCompoundCurve cc;
-  double width;
+  double width = -1.0; // width is set to correct value during first loop
   bool hadBulge( false );
 
   std::vector<DRW_Vertex2D *>::size_type n = data.flags & 1 ? vertexnum : vertexnum - 1;
@@ -1670,7 +1670,7 @@ void QgsDwgImporter::addPolyline( const DRW_Polyline &data )
 
   QgsPointSequence s;
   QgsCompoundCurve cc;
-  double width;
+  double width = -1.0; // width is set to correct value during first loop
   bool hadBulge( false );
 
   std::vector<DRW_Vertex *>::size_type n = data.flags & 1 ? vertexnum : vertexnum - 1;
diff --git a/src/app/qgisapp.h b/src/app/qgisapp.h
@@ -1647,7 +1647,7 @@ class APP_EXPORT QgisApp : public QMainWindow, private Ui::MainWindow
         QgsMapTool *mCircularStringCurvePoint;
         QgsMapTool *mCircularStringRadius;
         QgsMapTool *mMoveFeature;
-        QgsMapTool *mMoveFeatureCopy;
+        QgsMapTool *mMoveFeatureCopy = nullptr;
         QgsMapTool *mOffsetCurve;
         QgsMapTool *mReshapeFeatures;
         QgsMapTool *mSplitFeatures;
diff --git a/src/app/qgsselectbyformdialog.h b/src/app/qgsselectbyformdialog.h
@@ -67,10 +67,10 @@ class APP_EXPORT QgsSelectByFormDialog : public QDialog
 
   private:
 
-    QgsAttributeForm* mForm;
-    QgsVectorLayer* mLayer;
-    QgsMessageBar* mMessageBar;
-    QgsMapCanvas* mMapCanvas;
+    QgsAttributeForm* mForm = nullptr;
+    QgsVectorLayer* mLayer = nullptr;
+    QgsMessageBar* mMessageBar = nullptr;
+    QgsMapCanvas* mMapCanvas = nullptr;
 
 };
 
diff --git a/src/core/qgsaction.h b/src/core/qgsaction.h
@@ -187,7 +187,7 @@ class CORE_EXPORT QgsAction
     QString mShortTitle;
     QString mIcon;
     QString mCommand;
-    bool mCaptureOutput;
+    bool mCaptureOutput = false;
     QSet<QString> mActionScopes;
     mutable QSharedPointer<QAction> mAction;
     QUuid mId;
diff --git a/src/core/qgssnappingconfig.h b/src/core/qgssnappingconfig.h
@@ -237,12 +237,12 @@ class CORE_EXPORT QgsSnappingConfig
 
     //! associated project for this snapping configuration
     QgsProject* mProject;
-    bool mEnabled;
-    SnappingMode mMode;
-    SnappingType mType;
-    double mTolerance;
-    QgsTolerance::UnitType mUnits;
-    bool mIntersectionSnapping;
+    bool mEnabled = false;
+    SnappingMode mMode = ActiveLayer;
+    SnappingType mType = Vertex;
+    double mTolerance = 0.0;
+    QgsTolerance::UnitType mUnits = QgsTolerance::ProjectUnits;
+    bool mIntersectionSnapping = false;
 
     QHash<QgsVectorLayer*, IndividualLayerSettings> mIndividualLayerSettings;
 
diff --git a/src/server/qgsmslayercache.cpp b/src/server/qgsmslayercache.cpp
@@ -33,7 +33,6 @@ QgsMSLayerCache* QgsMSLayerCache::instance()
 }
 
 QgsMSLayerCache::QgsMSLayerCache()
-    : mProjectMaxLayers( 100 )
 {
   QObject::connect( &mFileSystemWatcher, SIGNAL( fileChanged( const QString& ) ), this, SLOT( removeProjectFileLayers( const QString& ) ) );
 }
diff --git a/src/server/qgsmslayercache.h b/src/server/qgsmslayercache.h
@@ -111,10 +111,10 @@ class QgsMSLayerCache: public QObject
     QFileSystemWatcher mFileSystemWatcher;
 
     //! Maximum number of layers in the cache
-    int mDefaultMaxLayers;
+    int mDefaultMaxLayers = 100;
 
     //! Maximum number of layers in the cache, overrides DEFAULT_MAX_N_LAYERS if larger
-    int mProjectMaxLayers;
+    int mProjectMaxLayers = 100;
 
   private slots:
 
diff --git a/src/server/qgsservicenativeloader.cpp b/src/server/qgsservicenativeloader.cpp
@@ -36,12 +36,11 @@ class QgsServiceNativeModuleEntry
   public:
     QgsServiceNativeModuleEntry( const QString& location )
         : mLocation( location )
-        , mModule( nullptr )
     {}
 
-    QString           mLocation;
-    QgsServiceModule* mModule;
-    unloadHook_t*     mUnloadHook;
+    QString mLocation;
+    QgsServiceModule* mModule = nullptr;
+    unloadHook_t* mUnloadHook = nullptr;
 };
 
 //! Constructor
diff --git a/tests/bench/qgsbench.cpp b/tests/bench/qgsbench.cpp
@@ -221,7 +221,8 @@ void QgsBench::render()
   mLogMap.insert( QStringLiteral( "revision" ), QGSVERSION );
 
   // Calc stats: user, sys, total
-  double min[4], max[4];
+  double min[4] = {DBL_MAX};
+  double max[4] = { -DBL_MAX};
   double stdev[4] = {0.};
   double maxdev[4] = {0.};
   double avg[4] = {0.};

Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,6 @@ QgsMSLayerCache* QgsMSLayerCache::instance()`
`33`	`33`	`}`
`34`	`34`
`35`	`35`	`QgsMSLayerCache::QgsMSLayerCache()`
`36`		`- : mProjectMaxLayers( 100 )`
`37`	`36`	`{`
`38`	`37`	`QObject::connect( &mFileSystemWatcher, SIGNAL( fileChanged( const QString& ) ), this, SLOT( removeProjectFileLayers( const QString& ) ) );`
`39`	`38`	`}`