Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[FEATURE][composer] Add tools for drawing polygon and polylines
- Loading branch information
1 parent
bde5126
commit 7a8a541
Showing
49 changed files
with
4,453 additions
and
43 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
7a8a541There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nyalldawson I get a compilation error:
`
Building CXX object src/core/CMakeFiles/qgis_core.dir/composer/qgscomposernodesitem.cpp.o
/home/webmaster/dev/cpp/QGIS/src/core/composer/qgscomposernodesitem.cpp: In member function ‘bool QgsComposerNodesItem::addNode(const QPointF&, bool, double)’:
/home/webmaster/dev/cpp/QGIS/src/core/composer/qgscomposernodesitem.cpp:82:22: error: ‘isinf’ was not declared in this scope
if ( isinf( coef ) )
/home/webmaster/dev/cpp/QGIS/src/core/composer/qgscomposernodesitem.cpp:82:22: note: suggested alternative:
In file included from /usr/include/c++/5/random:38:0,
from /usr/include/c++/5/bits/stl_algo.h:66,
from /usr/include/c++/5/algorithm:62,
from /usr/include/qt4/QtCore/qglobal.h:68,
from /usr/include/qt4/QtCore/qnamespace.h:45,
from /usr/include/qt4/QtCore/qobjectdefs.h:45,
from /usr/include/qt4/QtCore/qobject.h:47,
from /usr/include/qt4/QtGui/qundostack.h:45,
from /usr/include/qt4/QtGui/QUndoCommand:1,
from /home/webmaster/dev/cpp/QGIS/src/core/composer/qgscomposeritemcommand.h:21,
from /home/webmaster/dev/cpp/QGIS/src/core/composer/qgscomposeritem.h:20,
from /home/webmaster/dev/cpp/QGIS/src/core/composer/qgscomposernodesitem.h:20,
from /home/webmaster/dev/cpp/QGIS/src/core/composer/qgscomposernodesitem.cpp:17:
/usr/include/c++/5/cmath:621:5: note: ‘std::isinf’
isinf(_Tp __x)
^
`
(I'm on Ubuntu Xenial)
7a8a541There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nyalldawson your suggestion to use qIsInf instead of isinf works, making process is successful.
7a8a541There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pblottiere , @nyalldawson , spotted a serious issue with polyline which needs addressing: http://hub.qgis.org/issues/14611
A white fill is drawn for polyline items if [x] draw effects is enabled:
