Fix typo & return string by value not ref

qgis · Aug 16, 2021 · 7a7964c · 7a7964c
1 parent 74512ff
commit 7a7964c
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/python/gui/auto_generated/qgsexternalresourcewidget.sip.in b/python/gui/auto_generated/qgsexternalresourcewidget.sip.in
@@ -163,7 +163,7 @@ defined)
 .. versionadded:: 3.22
 %End
 
-    const QString &storageAuthConfigId() const;
+    QString storageAuthConfigId() const;
 %Docstring
 Returns the authentication configuration ID used for the current external storage (if defined)
 

diff --git a/src/gui/editorwidgets/qgsexternalresourceconfigdlg.cpp b/src/gui/editorwidgets/qgsexternalresourceconfigdlg.cpp
@@ -37,7 +37,7 @@ QgsExternalResourceConfigDlg::QgsExternalResourceConfigDlg( QgsVectorLayer *vl,
 {
   setupUi( this );
 
-  mStorageType->addItem( tr( "Select existing file" ), QString() );
+  mStorageType->addItem( tr( "Select Existing file" ), QString() );
   for ( QgsExternalStorage *storage : QgsApplication::externalStorageRegistry()->externalStorages() )
   {
     mStorageType->addItem( tr( "Store with %1" ).arg( storage->type() ), storage->type() );

diff --git a/src/gui/qgsexternalresourcewidget.cpp b/src/gui/qgsexternalresourcewidget.cpp
@@ -249,7 +249,7 @@ void QgsExternalResourceWidget::setStorageAuthConfigId( const QString &authCfg )
   mFileWidget->setStorageAuthConfigId( authCfg );
 }
 
-const QString &QgsExternalResourceWidget::storageAuthConfigId() const
+QString QgsExternalResourceWidget::storageAuthConfigId() const
 {
   return mFileWidget->storageAuthConfigId();
 }

diff --git a/src/gui/qgsexternalresourcewidget.h b/src/gui/qgsexternalresourcewidget.h
@@ -174,7 +174,7 @@ class GUI_EXPORT QgsExternalResourceWidget : public QWidget
      * Returns the authentication configuration ID used for the current external storage (if defined)
      * \since QGIS 3.22
      */
-    const QString &storageAuthConfigId() const;
+    QString storageAuthConfigId() const;
 
     /**
      * Set \a messageBar to report messages