Add return cases to the docs and fully qualified enums

elpaso · elpaso · commit 7a63a07f7f97 · 2017-11-24T11:53:49.000+01:00
diff --git a/python/core/qgsvectorlayer.sip b/python/core/qgsvectorlayer.sip
@@ -1049,6 +1049,13 @@ Return the provider type for this layer
  \param ring ring to add
  \param featureId if specified, feature ID for feature ring was added to will be stored in this parameter
  :return: QgsGeometry.OperationResult
+ - Success
+ - LayerNotEditable
+ - AddRingNotInExistingFeature
+ - InvalidInputGeometryType
+ - AddRingNotClosed
+ - AddRingNotValid
+ - AddRingCrossesExistingRings
  :rtype: QgsGeometry.OperationResult
 %End
 
@@ -1058,6 +1065,13 @@ Return the provider type for this layer
  \param ring ring to add
  \param featureId if specified, feature ID for feature ring was added to will be stored in this parameter
  :return: QgsGeometry.OperationResult
+ - Success
+ - LayerNotEditable
+ - AddRingNotInExistingFeature
+ - InvalidInputGeometryType
+ - AddRingNotClosed
+ - AddRingNotValid
+ - AddRingCrossesExistingRings
 .. note::
 
    available in Python as addCurvedRing
@@ -1068,13 +1082,29 @@ Return the provider type for this layer
 %Docstring
  Adds a new part polygon to a multipart feature
  :return: QgsGeometry.OperationResult
+ - Success
+ - LayerNotEditable
+ - SelectionIsEmpty
+ - SelectionIsGreaterThanOne
+ - AddPartSelectedGeometryNotFound
+ - AddPartNotMultiGeometry
+ - InvalidBaseGeometry
+ - InvalidInputGeometryType
  :rtype: QgsGeometry.OperationResult
 %End
 
     QgsGeometry::OperationResult addPart( const QgsPointSequence &ring ) /PyName=addPartV2/;
 %Docstring
  Adds a new part polygon to a multipart feature
  :return: QgsGeometry.OperationResult
+ - Success
+ - LayerNotEditable
+ - SelectionIsEmpty
+ - SelectionIsGreaterThanOne
+ - AddPartSelectedGeometryNotFound
+ - AddPartNotMultiGeometry
+ - InvalidBaseGeometry
+ - InvalidInputGeometryType
 .. note::
 
    available in Python bindings as addPartV2
@@ -1105,6 +1135,13 @@ Return the provider type for this layer
   \param splitLine line that splits the layer features
   \param topologicalEditing true if topological editing is enabled
   :return: QgsGeometry.OperationResult
+ - Success
+ - NothingHappened
+ - LayerNotEditable
+ - InvalidInputGeometryType
+ - InvalidBaseGeometry
+ - GeometryEngineError
+ - SplitCannotSplitPoint
  :rtype: QgsGeometry.OperationResult
 %End
 
@@ -1114,6 +1151,13 @@ Return the provider type for this layer
   \param splitLine line that splits the layer features
   \param topologicalEditing true if topological editing is enabled
   :return: QgsGeometry.OperationResult
+ - Success
+ - NothingHappened
+ - LayerNotEditable
+ - InvalidInputGeometryType
+ - InvalidBaseGeometry
+ - GeometryEngineError
+ - SplitCannotSplitPoint
  :rtype: QgsGeometry.OperationResult
 %End
 
diff --git a/src/core/geometry/qgsgeometry.cpp b/src/core/geometry/qgsgeometry.cpp
@@ -674,7 +674,7 @@ QgsGeometry::OperationResult QgsGeometry::addPart( QgsAbstractGeometry *part, Qg
         break;
       default:
         reset( nullptr );
-        return QgsGeometry::AddPartNotMultiGeometry;
+        return QgsGeometry::OperationResult::AddPartNotMultiGeometry;
     }
   }
   else
@@ -785,7 +785,7 @@ QgsGeometry::OperationResult QgsGeometry::splitGeometry( const QVector<QgsPointX
 {
   if ( !d->geometry )
   {
-    return InvalidBaseGeometry;
+    return QgsGeometry::OperationResult::InvalidBaseGeometry;
   }
 
   QVector<QgsGeometry > newGeoms;
@@ -808,19 +808,19 @@ QgsGeometry::OperationResult QgsGeometry::splitGeometry( const QVector<QgsPointX
   switch ( result )
   {
     case QgsGeometryEngine::Success:
-      return QgsGeometry::Success;
+      return QgsGeometry::OperationResult::Success;
     case QgsGeometryEngine::MethodNotImplemented:
     case QgsGeometryEngine::EngineError:
     case QgsGeometryEngine::NodedGeometryError:
-      return QgsGeometry::GeometryEngineError;
+      return QgsGeometry::OperationResult::GeometryEngineError;
     case QgsGeometryEngine::InvalidBaseGeometry:
-      return QgsGeometry::InvalidBaseGeometry;
+      return QgsGeometry::OperationResult::InvalidBaseGeometry;
     case QgsGeometryEngine::InvalidInput:
-      return QgsGeometry::InvalidInputGeometryType;
+      return QgsGeometry::OperationResult::InvalidInputGeometryType;
     case QgsGeometryEngine::SplitCannotSplitPoint:
-      return QgsGeometry::SplitCannotSplitPoint;
+      return QgsGeometry::OperationResult::SplitCannotSplitPoint;
     case QgsGeometryEngine::NothingHappened:
-      return QgsGeometry::NothingHappened;
+      return QgsGeometry::OperationResult::NothingHappened;
       //default: do not implement default to handle properly all cases
   }
 
diff --git a/src/core/geometry/qgsgeometryeditutils.cpp b/src/core/geometry/qgsgeometryeditutils.cpp
@@ -50,17 +50,17 @@ QgsGeometry::OperationResult QgsGeometryEditUtils::addRing( QgsAbstractGeometry
   }
   else
   {
-    return QgsGeometry::InvalidInputGeometryType; //not polygon / multipolygon;
+    return QgsGeometry::OperationResult::InvalidInputGeometryType; //not polygon / multipolygon;
   }
 
   //ring must be closed
   if ( !ring->isClosed() )
   {
-    return QgsGeometry::AddRingNotClosed;
+    return QgsGeometry::OperationResult::AddRingNotClosed;
   }
   else if ( !ring->isRing() )
   {
-    return QgsGeometry::AddRingNotValid;
+    return QgsGeometry::OperationResult::AddRingNotValid;
   }
 
   std::unique_ptr<QgsGeometryEngine> ringGeom( QgsGeometry::createGeometryEngine( ring.get() ) );
@@ -78,7 +78,7 @@ QgsGeometry::OperationResult QgsGeometryEditUtils::addRing( QgsAbstractGeometry
       {
         if ( !ringGeom->disjoint( ( *polyIter )->interiorRing( i ) ) )
         {
-          return QgsGeometry::AddRingCrossesExistingRings;
+          return QgsGeometry::OperationResult::AddRingCrossesExistingRings;
         }
       }
 
@@ -89,29 +89,29 @@ QgsGeometry::OperationResult QgsGeometryEditUtils::addRing( QgsAbstractGeometry
         ring->addMValue( 0 );
 
       ( *polyIter )->addInteriorRing( ring.release() );
-      return QgsGeometry::Success; //success
+      return QgsGeometry::OperationResult::Success; //success
     }
   }
-  return QgsGeometry::AddRingNotInExistingFeature; //not contained in any outer ring
+  return QgsGeometry::OperationResult::AddRingNotInExistingFeature; //not contained in any outer ring
 }
 
 QgsGeometry::OperationResult QgsGeometryEditUtils::addPart( QgsAbstractGeometry *geom, std::unique_ptr<QgsAbstractGeometry> part )
 {
   if ( !geom )
   {
-    return QgsGeometry::InvalidBaseGeometry;
+    return QgsGeometry::OperationResult::InvalidBaseGeometry;
   }
 
   if ( !part )
   {
-    return QgsGeometry::InvalidInputGeometryType;
+    return QgsGeometry::OperationResult::InvalidInputGeometryType;
   }
 
   //multitype?
   QgsGeometryCollection *geomCollection = qgsgeometry_cast<QgsGeometryCollection *>( geom );
   if ( !geomCollection )
   {
-    return QgsGeometry::AddPartNotMultiGeometry;
+    return QgsGeometry::OperationResult::AddPartNotMultiGeometry;
   }
 
   bool added = false;
@@ -155,19 +155,19 @@ QgsGeometry::OperationResult QgsGeometryEditUtils::addPart( QgsAbstractGeometry
       {
         while ( geomCollection->numGeometries() > n )
           geomCollection->removeGeometry( n );
-        return QgsGeometry::InvalidInputGeometryType;
+        return QgsGeometry::OperationResult::InvalidInputGeometryType;
       }
     }
     else
     {
-      return QgsGeometry::InvalidInputGeometryType;
+      return QgsGeometry::OperationResult::InvalidInputGeometryType;
     }
   }
   else
   {
     added = geomCollection->addGeometry( part.release() );
   }
-  return added ? QgsGeometry::Success : QgsGeometry::InvalidInputGeometryType;
+  return added ? QgsGeometry::Success : QgsGeometry::OperationResult::InvalidInputGeometryType;
 }
 
 bool QgsGeometryEditUtils::deleteRing( QgsAbstractGeometry *geom, int ringNum, int partNum )
diff --git a/src/core/qgsvectorlayer.h b/src/core/qgsvectorlayer.h
@@ -1050,6 +1050,13 @@ class CORE_EXPORT QgsVectorLayer : public QgsMapLayer, public QgsExpressionConte
      * \param ring ring to add
      * \param featureId if specified, feature ID for feature ring was added to will be stored in this parameter
      * \returns QgsGeometry::OperationResult
+     * - Success
+     * - LayerNotEditable
+     * - AddRingNotInExistingFeature
+     * - InvalidInputGeometryType
+     * - AddRingNotClosed
+     * - AddRingNotValid
+     * - AddRingCrossesExistingRings
      */
     QgsGeometry::OperationResult addRing( const QVector<QgsPointXY> &ring, QgsFeatureId *featureId = nullptr );
 
@@ -1058,19 +1065,42 @@ class CORE_EXPORT QgsVectorLayer : public QgsMapLayer, public QgsExpressionConte
      * \param ring ring to add
      * \param featureId if specified, feature ID for feature ring was added to will be stored in this parameter
      * \returns QgsGeometry::OperationResult
+     * - Success
+     * - LayerNotEditable
+     * - AddRingNotInExistingFeature
+     * - InvalidInputGeometryType
+     * - AddRingNotClosed
+     * - AddRingNotValid
+     * - AddRingCrossesExistingRings
      * \note available in Python as addCurvedRing
      */
     QgsGeometry::OperationResult addRing( QgsCurve *ring SIP_TRANSFER, QgsFeatureId *featureId = nullptr ) SIP_PYNAME( addCurvedRing );
 
     /**
      * Adds a new part polygon to a multipart feature
      * \returns QgsGeometry::OperationResult
+     * - Success
+     * - LayerNotEditable
+     * - SelectionIsEmpty
+     * - SelectionIsGreaterThanOne
+     * - AddPartSelectedGeometryNotFound
+     * - AddPartNotMultiGeometry
+     * - InvalidBaseGeometry
+     * - InvalidInputGeometryType
      */
     QgsGeometry::OperationResult addPart( const QList<QgsPointXY> &ring );
 
     /**
      * Adds a new part polygon to a multipart feature
      * \returns QgsGeometry::OperationResult
+     * - Success
+     * - LayerNotEditable
+     * - SelectionIsEmpty
+     * - SelectionIsGreaterThanOne
+     * - AddPartSelectedGeometryNotFound
+     * - AddPartNotMultiGeometry
+     * - InvalidBaseGeometry
+     * - InvalidInputGeometryType
      * \note available in Python bindings as addPartV2
      */
     QgsGeometry::OperationResult addPart( const QgsPointSequence &ring ) SIP_PYNAME( addPartV2 );
@@ -1092,6 +1122,13 @@ class CORE_EXPORT QgsVectorLayer : public QgsMapLayer, public QgsExpressionConte
      *  \param splitLine line that splits the layer features
      *  \param topologicalEditing true if topological editing is enabled
      *  \returns QgsGeometry::OperationResult
+     * - Success
+     * - NothingHappened
+     * - LayerNotEditable
+     * - InvalidInputGeometryType
+     * - InvalidBaseGeometry
+     * - GeometryEngineError
+     * - SplitCannotSplitPoint
      */
     QgsGeometry::OperationResult splitParts( const QVector<QgsPointXY> &splitLine, bool topologicalEditing = false );
 
@@ -1100,6 +1137,13 @@ class CORE_EXPORT QgsVectorLayer : public QgsMapLayer, public QgsExpressionConte
      *  \param splitLine line that splits the layer features
      *  \param topologicalEditing true if topological editing is enabled
      *  \returns QgsGeometry::OperationResult
+     * - Success
+     * - NothingHappened
+     * - LayerNotEditable
+     * - InvalidInputGeometryType
+     * - InvalidBaseGeometry
+     * - GeometryEngineError
+     * - SplitCannotSplitPoint
      */
     QgsGeometry::OperationResult splitFeatures( const QVector<QgsPointXY> &splitLine, bool topologicalEditing = false );
 
diff --git a/src/core/qgsvectorlayereditutils.cpp b/src/core/qgsvectorlayereditutils.cpp

Original file line number	Diff line number	Diff line change
`@@ -50,17 +50,17 @@ QgsGeometry::OperationResult QgsGeometryEditUtils::addRing( QgsAbstractGeometry`
`50`	`50`	`}`
`51`	`51`	`else`
`52`	`52`	`{`
`53`		`- return QgsGeometry::InvalidInputGeometryType; //not polygon / multipolygon;`
	`53`	`+ return QgsGeometry::OperationResult::InvalidInputGeometryType; //not polygon / multipolygon;`
`54`	`54`	`}`
`55`	`55`
`56`	`56`	`//ring must be closed`
`57`	`57`	`if ( !ring->isClosed() )`
`58`	`58`	`{`
`59`		`- return QgsGeometry::AddRingNotClosed;`
	`59`	`+ return QgsGeometry::OperationResult::AddRingNotClosed;`
`60`	`60`	`}`
`61`	`61`	`else if ( !ring->isRing() )`
`62`	`62`	`{`
`63`		`- return QgsGeometry::AddRingNotValid;`
	`63`	`+ return QgsGeometry::OperationResult::AddRingNotValid;`
`64`	`64`	`}`
`65`	`65`
`66`	`66`	`std::unique_ptr<QgsGeometryEngine> ringGeom( QgsGeometry::createGeometryEngine( ring.get() ) );`
`@@ -78,7 +78,7 @@ QgsGeometry::OperationResult QgsGeometryEditUtils::addRing( QgsAbstractGeometry`
`78`	`78`	`{`
`79`	`79`	`if ( !ringGeom->disjoint( ( *polyIter )->interiorRing( i ) ) )`
`80`	`80`	`{`
`81`		`- return QgsGeometry::AddRingCrossesExistingRings;`
	`81`	`+ return QgsGeometry::OperationResult::AddRingCrossesExistingRings;`
`82`	`82`	`}`
`83`	`83`	`}`
`84`	`84`
`@@ -89,29 +89,29 @@ QgsGeometry::OperationResult QgsGeometryEditUtils::addRing( QgsAbstractGeometry`
`89`	`89`	`ring->addMValue( 0 );`
`90`	`90`
`91`	`91`	`( *polyIter )->addInteriorRing( ring.release() );`
`92`		`- return QgsGeometry::Success; //success`
	`92`	`+ return QgsGeometry::OperationResult::Success; //success`
`93`	`93`	`}`
`94`	`94`	`}`
`95`		`- return QgsGeometry::AddRingNotInExistingFeature; //not contained in any outer ring`
	`95`	`+ return QgsGeometry::OperationResult::AddRingNotInExistingFeature; //not contained in any outer ring`
`96`	`96`	`}`
`97`	`97`
`98`	`98`	`QgsGeometry::OperationResult QgsGeometryEditUtils::addPart( QgsAbstractGeometry *geom, std::unique_ptr<QgsAbstractGeometry> part )`
`99`	`99`	`{`
`100`	`100`	`if ( !geom )`
`101`	`101`	`{`
`102`		`- return QgsGeometry::InvalidBaseGeometry;`
	`102`	`+ return QgsGeometry::OperationResult::InvalidBaseGeometry;`
`103`	`103`	`}`
`104`	`104`
`105`	`105`	`if ( !part )`
`106`	`106`	`{`
`107`		`- return QgsGeometry::InvalidInputGeometryType;`
	`107`	`+ return QgsGeometry::OperationResult::InvalidInputGeometryType;`
`108`	`108`	`}`
`109`	`109`
`110`	`110`	`//multitype?`
`111`	`111`	`QgsGeometryCollection geomCollection = qgsgeometry_cast<QgsGeometryCollection >( geom );`
`112`	`112`	`if ( !geomCollection )`
`113`	`113`	`{`
`114`		`- return QgsGeometry::AddPartNotMultiGeometry;`
	`114`	`+ return QgsGeometry::OperationResult::AddPartNotMultiGeometry;`
`115`	`115`	`}`
`116`	`116`
`117`	`117`	`bool added = false;`
`@@ -155,19 +155,19 @@ QgsGeometry::OperationResult QgsGeometryEditUtils::addPart( QgsAbstractGeometry`
`155`	`155`	`{`
`156`	`156`	`while ( geomCollection->numGeometries() > n )`
`157`	`157`	`geomCollection->removeGeometry( n );`
`158`		`- return QgsGeometry::InvalidInputGeometryType;`
	`158`	`+ return QgsGeometry::OperationResult::InvalidInputGeometryType;`
`159`	`159`	`}`
`160`	`160`	`}`
`161`	`161`	`else`
`162`	`162`	`{`
`163`		`- return QgsGeometry::InvalidInputGeometryType;`
	`163`	`+ return QgsGeometry::OperationResult::InvalidInputGeometryType;`
`164`	`164`	`}`
`165`	`165`	`}`
`166`	`166`	`else`
`167`	`167`	`{`
`168`	`168`	`added = geomCollection->addGeometry( part.release() );`
`169`	`169`	`}`
`170`		`- return added ? QgsGeometry::Success : QgsGeometry::InvalidInputGeometryType;`
	`170`	`+ return added ? QgsGeometry::Success : QgsGeometry::OperationResult::InvalidInputGeometryType;`
`171`	`171`	`}`
`172`	`172`
`173`	`173`	`bool QgsGeometryEditUtils::deleteRing( QgsAbstractGeometry *geom, int ringNum, int partNum )`
Original file line number	Diff line number	Diff line change
`@@ -184,13 +184,13 @@ QgsGeometry::OperationResult QgsVectorLayerEditUtils::addPart( const QList<QgsPo`
`184`	`184`	`QgsGeometry::OperationResult QgsVectorLayerEditUtils::addPart( const QgsPointSequence &points, QgsFeatureId featureId )`
`185`	`185`	`{`
`186`	`186`	`if ( !mLayer->isSpatial() )`
`187`		`- return QgsGeometry::AddPartSelectedGeometryNotFound;`
	`187`	`+ return QgsGeometry::OperationResult::AddPartSelectedGeometryNotFound;`
`188`	`188`
`189`	`189`	`QgsGeometry geometry;`
`190`	`190`	`bool firstPart = false;`
`191`	`191`	`QgsFeature f;`
`192`	`192`	`if ( !mLayer->getFeatures( QgsFeatureRequest().setFilterFid( featureId ).setSubsetOfAttributes( QgsAttributeList() ) ).nextFeature( f ) )`
`193`		`- return QgsGeometry::AddPartSelectedGeometryNotFound; //not found`
	`193`	`+ return QgsGeometry::OperationResult::AddPartSelectedGeometryNotFound; //not found`
`194`	`194`
`195`	`195`	`if ( !f.hasGeometry() )`
`196`	`196`	`{`
`@@ -279,7 +279,7 @@ QgsGeometry::OperationResult QgsVectorLayerEditUtils::splitFeatures( const QVect`
`279`	`279`
`280`	`280`	`double xMin, yMin, xMax, yMax;`
`281`	`281`	`QgsRectangle bBox; //bounding box of the split line`
`282`		`- QgsGeometry::OperationResult returnCode = QgsGeometry::Success;`
	`282`	`+ QgsGeometry::OperationResult returnCode = QgsGeometry::OperationResult::Success;`
`283`	`283`	`QgsGeometry::OperationResult splitFunctionReturn; //return code of QgsGeometry::splitGeometry`
`284`	`284`	`int numberOfSplitFeatures = 0;`
`285`	`285`
`@@ -301,7 +301,7 @@ QgsGeometry::OperationResult QgsVectorLayerEditUtils::splitFeatures( const QVect`
`301`	`301`	`}`
`302`	`302`	`else`
`303`	`303`	`{`
`304`		`- return QgsGeometry::InvalidInputGeometryType;`
	`304`	`+ return QgsGeometry::OperationResult::InvalidInputGeometryType;`
`305`	`305`	`}`
`306`	`306`
`307`	`307`	`if ( bBox.isEmpty() )`
`@@ -344,7 +344,7 @@ QgsGeometry::OperationResult QgsVectorLayerEditUtils::splitFeatures( const QVect`
`344`	`344`	`QVector<QgsPointXY> topologyTestPoints;`
`345`	`345`	`QgsGeometry featureGeom = feat.geometry();`
`346`	`346`	`splitFunctionReturn = featureGeom.splitGeometry( splitLine, newGeometries, topologicalEditing, topologyTestPoints );`
`347`		`- if ( splitFunctionReturn == QgsGeometry::Success )`
	`347`	`+ if ( splitFunctionReturn == QgsGeometry::OperationResult::Success )`
`348`	`348`	`{`
`349`	`349`	`//change this geometry`
`350`	`350`	`mLayer->editBuffer()->changeGeometry( feat.id(), featureGeom );`
`@@ -366,7 +366,7 @@ QgsGeometry::OperationResult QgsVectorLayerEditUtils::splitFeatures( const QVect`
`366`	`366`	`}`
`367`	`367`	`++numberOfSplitFeatures;`
`368`	`368`	`}`
`369`		`- else if ( splitFunctionReturn != QgsGeometry::Success && splitFunctionReturn != QgsGeometry::NothingHappened ) // i.e. no split but no error occurred`
	`369`	`+ else if ( splitFunctionReturn != QgsGeometry::OperationResult::Success && splitFunctionReturn != QgsGeometry::NothingHappened ) // i.e. no split but no error occurred`
`370`	`370`	`{`
`371`	`371`	`returnCode = splitFunctionReturn;`
`372`	`372`	`}`
`@@ -376,7 +376,7 @@ QgsGeometry::OperationResult QgsVectorLayerEditUtils::splitFeatures( const QVect`
`376`	`376`	`{`
`377`	`377`	`//There is a selection but no feature has been split.`
`378`	`378`	`//Maybe user forgot that only the selected features are split`
`379`		`- returnCode = QgsGeometry::NothingHappened;`
	`379`	`+ returnCode = QgsGeometry::OperationResult::NothingHappened;`
`380`	`380`	`}`
`381`	`381`
`382`	`382`	`return returnCode;`
`@@ -389,7 +389,7 @@ QgsGeometry::OperationResult QgsVectorLayerEditUtils::splitParts( const QVector<`
`389`	`389`
`390`	`390`	`double xMin, yMin, xMax, yMax;`
`391`	`391`	`QgsRectangle bBox; //bounding box of the split line`
`392`		`- QgsGeometry::OperationResult returnCode = QgsGeometry::Success;`
	`392`	`+ QgsGeometry::OperationResult returnCode = QgsGeometry::OperationResult::Success;`
`393`	`393`	`QgsGeometry::OperationResult splitFunctionReturn; //return code of QgsGeometry::splitGeometry`
`394`	`394`	`int numberOfSplitParts = 0;`
`395`	`395`
`@@ -410,7 +410,7 @@ QgsGeometry::OperationResult QgsVectorLayerEditUtils::splitParts( const QVector<`
`410`	`410`	`}`
`411`	`411`	`else`
`412`	`412`	`{`
`413`		`- return QgsGeometry::InvalidInputGeometryType;`
	`413`	`+ return QgsGeometry::OperationResult::InvalidInputGeometryType;`
`414`	`414`	`}`
`415`	`415`
`416`	`416`	`if ( bBox.isEmpty() )`
`@@ -442,7 +442,7 @@ QgsGeometry::OperationResult QgsVectorLayerEditUtils::splitParts( const QVector<`
`442`	`442`	`fit = mLayer->getFeatures( QgsFeatureRequest().setFilterRect( bBox ).setFlags( QgsFeatureRequest::ExactIntersect ) );`
`443`	`443`	`}`
`444`	`444`
`445`		`- QgsGeometry::OperationResult addPartRet = QgsGeometry::Success;`
	`445`	`+ QgsGeometry::OperationResult addPartRet = QgsGeometry::OperationResult::Success;`
`446`	`446`
`447`	`447`	`QgsFeature feat;`
`448`	`448`	`while ( fit.nextFeature( feat ) )`
`@@ -482,7 +482,7 @@ QgsGeometry::OperationResult QgsVectorLayerEditUtils::splitParts( const QVector<`
`482`	`482`	`}`
`483`	`483`	`++numberOfSplitParts;`
`484`	`484`	`}`
`485`		`- else if ( splitFunctionReturn != QgsGeometry::Success && splitFunctionReturn != QgsGeometry::NothingHappened )`
	`485`	`+ else if ( splitFunctionReturn != QgsGeometry::OperationResult::Success && splitFunctionReturn != QgsGeometry::OperationResult::NothingHappened )`
`486`	`486`	`{`
`487`	`487`	`returnCode = splitFunctionReturn;`
`488`	`488`	`}`
`@@ -492,7 +492,7 @@ QgsGeometry::OperationResult QgsVectorLayerEditUtils::splitParts( const QVector<`
`492`	`492`	`{`
`493`	`493`	`//There is a selection but no feature has been split.`
`494`	`494`	`//Maybe user forgot that only the selected features are split`
`495`		`- returnCode = QgsGeometry::NothingHappened;`
	`495`	`+ returnCode = QgsGeometry::OperationResult::NothingHappened;`
`496`	`496`	`}`
`497`	`497`
`498`	`498`	`return returnCode;`