Skip to content

Commit

Permalink
fix doc and typos
Browse files Browse the repository at this point in the history
  • Loading branch information
troopa81 committed Feb 27, 2023
1 parent f8c1c16 commit 7a2a252
Show file tree
Hide file tree
Showing 8 changed files with 38 additions and 11 deletions.
2 changes: 1 addition & 1 deletion python/core/auto_generated/qgsrendercontext.sip.in
Expand Up @@ -136,7 +136,7 @@ Sets the list of disabled symbol layer ids.

.. seealso:: :py:func:`disabledSymbolLayersV2`

.. seealso:: :py:func:`isSymbolLayerEnabledV2`
.. seealso:: :py:func:`isSymbolLayerEnabled`

.. versionadded:: 3.30
%End
Expand Down
8 changes: 4 additions & 4 deletions python/core/auto_generated/symbology/qgssymbollayer.sip.in
Expand Up @@ -645,9 +645,9 @@ This is a list of symbol layers of other layers that should be occluded.
Prepares all mask internal objects according to what is defined in ``context``
This should be called prior to calling :py:func:`~QgsSymbolLayer.startRender` method.

.. seealso:: :py:func:`addSymbolLayerClipPath`
.. seealso:: :py:func:`QgsRenderContext.addSymbolLayerClipPath`

.. seealso:: :py:func:`symbolLayerClipPaths`
.. seealso:: :py:func:`QgsRenderContext.symbolLayerClipPaths`

.. versionadded:: 3.26
%End
Expand Down Expand Up @@ -709,7 +709,7 @@ Copies paint effect of this layer to another symbol layer

void installMasks( QgsRenderContext &context, bool recursive );
%Docstring
When renderering, install masks on ``context`` painter
When rendering, install masks on ``context`` painter
if ``recursive`` is ``True`` masks are installed recursively for all children symbol layers

.. seealso:: :py:func:`prepareMasks`
Expand All @@ -721,7 +721,7 @@ if ``recursive`` is ``True`` masks are installed recursively for all children sy

void removeMasks( QgsRenderContext &context, bool recursive );
%Docstring
When renderering, remove previously installed masks from ``context`` painter
When rendering, remove previously installed masks from ``context`` painter
if ``recursive`` is ``True`` masks are removed recursively for all children symbol layers

.. seealso:: :py:func:`prepareMasks`
Expand Down
Expand Up @@ -113,9 +113,22 @@ Default constructor
QgsSymbolLayerReference( const QString &layerId, const QgsSymbolLayerId &symbolLayer );
%Docstring
Constructor

:param layerId: layer id
:param symbolLayer: symbol layer id

.. deprecated:: QGIS 3.30
%End

QgsSymbolLayerReference( const QString &layerId, const QString &symbolLayerId );
%Docstring
Constructor

:param layerId: layer id
:param symbolLayerId: symbol layer id

.. versionadded:: 3.30
%End

QString layerId() const;
%Docstring
Expand Down
Expand Up @@ -1043,6 +1043,8 @@ key (rule for :py:class:`QgsRuleBasedRenderer` for instance) and index path, so
to new ones.

.. versionadded:: 3.30

.. deprecated:: QGIS 3.30
%End

static void clearSymbolLayerIds( QgsSymbol *symbol );
Expand Down
2 changes: 1 addition & 1 deletion src/core/qgsrendercontext.h
Expand Up @@ -164,7 +164,7 @@ class CORE_EXPORT QgsRenderContext : public QgsTemporalRangeObject
*
* Sets the list of disabled symbol layer ids.
* \see disabledSymbolLayersV2()
* \see isSymbolLayerEnabledV2()
* \see isSymbolLayerEnabled()
* \since QGIS 3.30
*/
void setDisabledSymbolLayersV2( const QSet<QString> &symbolLayers );
Expand Down
8 changes: 4 additions & 4 deletions src/core/symbology/qgssymbollayer.h
Expand Up @@ -626,8 +626,8 @@ class CORE_EXPORT QgsSymbolLayer
/**
* Prepares all mask internal objects according to what is defined in \a context
* This should be called prior to calling startRender() method.
* \see addSymbolLayerClipPath()
* \see symbolLayerClipPaths()
* \see QgsRenderContext::addSymbolLayerClipPath()
* \see QgsRenderContext::symbolLayerClipPaths()
* \since QGIS 3.26
*/
virtual void prepareMasks( const QgsSymbolRenderContext &context );
Expand Down Expand Up @@ -700,7 +700,7 @@ class CORE_EXPORT QgsSymbolLayer
void copyPaintEffect( QgsSymbolLayer *destLayer ) const;

/**
* When renderering, install masks on \a context painter
* When rendering, install masks on \a context painter
* if \a recursive is TRUE masks are installed recursively for all children symbol layers
* \see prepareMasks()
* \see removeMasks()
Expand All @@ -709,7 +709,7 @@ class CORE_EXPORT QgsSymbolLayer
void installMasks( QgsRenderContext &context, bool recursive );

/**
* When renderering, remove previously installed masks from \a context painter
* When rendering, remove previously installed masks from \a context painter
* if \a recursive is TRUE masks are removed recursively for all children symbol layers
* \see prepareMasks()
* \see installMasks()
Expand Down
13 changes: 12 additions & 1 deletion src/core/symbology/qgssymbollayerreference.h
Expand Up @@ -140,11 +140,22 @@ class CORE_EXPORT QgsSymbolLayerReference
//! Default constructor
QgsSymbolLayerReference() = default;

//! Constructor
/**
* Constructor
* \param layerId layer id
* \param symbolLayer symbol layer id
* \deprecated since QGIS 3.30
*/
Q_DECL_DEPRECATED QgsSymbolLayerReference( const QString &layerId, const QgsSymbolLayerId &symbolLayer )
: mLayerId( layerId ), mDeprecatedSymbolLayerId( symbolLayer )
{}

/**
* Constructor
* \param layerId layer id
* \param symbolLayerId symbol layer id
* \since QGIS 3.30
*/
QgsSymbolLayerReference( const QString &layerId, const QString &symbolLayerId )
: mLayerId( layerId ), mSymbolLayerId( symbolLayerId )
{}
Expand Down
1 change: 1 addition & 0 deletions src/core/symbology/qgssymbollayerutils.h
Expand Up @@ -934,6 +934,7 @@ class CORE_EXPORT QgsSymbolLayerUtils
* key (rule for QgsRuleBasedRenderer for instance) and index path, so this method migrates \a mapLayers old references
* to new ones.
* \since QGIS 3.30
* \deprecated since QGIS 3.30
*/
Q_DECL_DEPRECATED static void fixOldSymbolLayerReferences( const QMap<QString, QgsMapLayer *> &mapLayers );

Expand Down

0 comments on commit 7a2a252

Please sign in to comment.