Pass the full ogr data source URI as connInfo in qgsConnectionPool_ConnectionCreate.

manisandro · manisandro · commit 79493ea39492 · 2016-04-26T16:02:10.000+02:00
This fixes corrupt rendering when loading the same dataset twice with different options (i.e. layers), see issue #14560.
diff --git a/src/providers/ogr/qgsogrconnpool.h b/src/providers/ogr/qgsogrconnpool.h
@@ -35,7 +35,8 @@ inline QString qgsConnectionPool_ConnectionToName( QgsOgrConn* c )
 inline void qgsConnectionPool_ConnectionCreate( QString connInfo, QgsOgrConn*& c )
 {
   c = new QgsOgrConn;
-  c->ds = OGROpen( connInfo.toUtf8().constData(), false, nullptr );
+  QString filePath = connInfo.left( connInfo.indexOf( "|" ) );
+  c->ds = OGROpen( filePath.toUtf8().constData(), false, nullptr );
   c->path = connInfo;
   c->valid = true;
 }
diff --git a/src/providers/ogr/qgsogrfeatureiterator.cpp b/src/providers/ogr/qgsogrfeatureiterator.cpp
@@ -44,7 +44,7 @@ QgsOgrFeatureIterator::QgsOgrFeatureIterator( QgsOgrFeatureSource* source, bool
 {
   mFeatureFetched = false;
 
-  mConn = QgsOgrConnPool::instance()->acquireConnection( mSource->mFilePath );
+  mConn = QgsOgrConnPool::instance()->acquireConnection( mSource->mProvider->dataSourceUri() );
 
   if ( mSource->mLayerName.isNull() )
   {
@@ -348,20 +348,20 @@ bool QgsOgrFeatureIterator::readFeature( OGRFeatureH fet, QgsFeature& feature )
 QgsOgrFeatureSource::QgsOgrFeatureSource( const QgsOgrProvider* p )
     : mProvider( p )
 {
-  mFilePath = p->filePath();
+  mDataSource = p->dataSourceUri();
   mLayerName = p->layerName();
   mLayerIndex = p->layerIndex();
   mSubsetString = p->mSubsetString;
   mEncoding = p->mEncoding; // no copying - this is a borrowed pointer from Qt
   mFields = p->mAttributeFields;
   mDriverName = p->ogrDriverName;
   mOgrGeometryTypeFilter = wkbFlatten( p->mOgrGeometryTypeFilter );
-  QgsOgrConnPool::instance()->ref( mFilePath );
+  QgsOgrConnPool::instance()->ref( mDataSource );
 }
 
 QgsOgrFeatureSource::~QgsOgrFeatureSource()
 {
-  QgsOgrConnPool::instance()->unref( mFilePath );
+  QgsOgrConnPool::instance()->unref( mDataSource );
 }
 
 QgsFeatureIterator QgsOgrFeatureSource::getFeatures( const QgsFeatureRequest& request )
diff --git a/src/providers/ogr/qgsogrfeatureiterator.h b/src/providers/ogr/qgsogrfeatureiterator.h
@@ -34,7 +34,7 @@ class QgsOgrFeatureSource : public QgsAbstractFeatureSource
 
   protected:
     const QgsOgrProvider* mProvider;
-    QString mFilePath;
+    QString mDataSource;
     QString mLayerName;
     int mLayerIndex;
     QString mSubsetString;

Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,8 @@ inline QString qgsConnectionPool_ConnectionToName( QgsOgrConn* c )`
`35`	`35`	`inline void qgsConnectionPool_ConnectionCreate( QString connInfo, QgsOgrConn*& c )`
`36`	`36`	`{`
`37`	`37`	`c = new QgsOgrConn;`
`38`		`- c->ds = OGROpen( connInfo.toUtf8().constData(), false, nullptr );`
	`38`	`+ QString filePath = connInfo.left( connInfo.indexOf( "\|" ) );`
	`39`	`+ c->ds = OGROpen( filePath.toUtf8().constData(), false, nullptr );`
`39`	`40`	`c->path = connInfo;`
`40`	`41`	`c->valid = true;`
`41`	`42`	`}`
Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ QgsOgrFeatureIterator::QgsOgrFeatureIterator( QgsOgrFeatureSource* source, bool`
`44`	`44`	`{`
`45`	`45`	`mFeatureFetched = false;`
`46`	`46`
`47`		`- mConn = QgsOgrConnPool::instance()->acquireConnection( mSource->mFilePath );`
	`47`	`+ mConn = QgsOgrConnPool::instance()->acquireConnection( mSource->mProvider->dataSourceUri() );`
`48`	`48`
`49`	`49`	`if ( mSource->mLayerName.isNull() )`
`50`	`50`	`{`
`@@ -348,20 +348,20 @@ bool QgsOgrFeatureIterator::readFeature( OGRFeatureH fet, QgsFeature& feature )`
`348`	`348`	`QgsOgrFeatureSource::QgsOgrFeatureSource( const QgsOgrProvider* p )`
`349`	`349`	`: mProvider( p )`
`350`	`350`	`{`
`351`		`- mFilePath = p->filePath();`
	`351`	`+ mDataSource = p->dataSourceUri();`
`352`	`352`	`mLayerName = p->layerName();`
`353`	`353`	`mLayerIndex = p->layerIndex();`
`354`	`354`	`mSubsetString = p->mSubsetString;`
`355`	`355`	`mEncoding = p->mEncoding; // no copying - this is a borrowed pointer from Qt`
`356`	`356`	`mFields = p->mAttributeFields;`
`357`	`357`	`mDriverName = p->ogrDriverName;`
`358`	`358`	`mOgrGeometryTypeFilter = wkbFlatten( p->mOgrGeometryTypeFilter );`
`359`		`- QgsOgrConnPool::instance()->ref( mFilePath );`
	`359`	`+ QgsOgrConnPool::instance()->ref( mDataSource );`
`360`	`360`	`}`
`361`	`361`
`362`	`362`	`QgsOgrFeatureSource::~QgsOgrFeatureSource()`
`363`	`363`	`{`
`364`		`- QgsOgrConnPool::instance()->unref( mFilePath );`
	`364`	`+ QgsOgrConnPool::instance()->unref( mDataSource );`
`365`	`365`	`}`
`366`	`366`
`367`	`367`	`QgsFeatureIterator QgsOgrFeatureSource::getFeatures( const QgsFeatureRequest& request )`