Skip to content

Commit

Permalink
about box: use webview for version info and use ok button
Browse files Browse the repository at this point in the history
  • Loading branch information
@jef-n
jef-n committed Jan 18, 2013
1 parent 087e929 commit 7809cbd
Showing 1 changed file with 7 additions and 10 deletions.
17 changes: 7 additions & 10 deletions src/ui/qgsabout.ui
View file
Expand Up @@ -20,7 +20,7 @@
<item row="1" column="0">
<widget class="QDialogButtonBox" name="buttonBox">
<property name="standardButtons">
<set>QDialogButtonBox::Close</set>

This comment has been minimized.

Sign in to view

Copy link
@NathanW2

NathanW2 Jan 20, 2013

Member

Using Close here makes more sense as we are not asking the user to confirm something which is what OK is implying.

This comment has been minimized.

Sign in to view

Copy link
@jef-n

jef-n Jan 21, 2013

Author Member

But OK closes the dialog now, which "Close" didn't.
<set>QDialogButtonBox::Ok</set>
</property>
</widget>
</item>
Expand Down Expand Up @@ -141,15 +141,11 @@ p, li { white-space: pre-wrap; }
</layout>
</item>
<item row="1" column="0">
<widget class="QTextEdit" name="txtVersion">
<property name="frameShape">
<enum>QFrame::NoFrame</enum>
</property>
<property name="frameShadow">
<enum>QFrame::Plain</enum>
</property>
<property name="readOnly">
<bool>true</bool>
<widget class="QWebView" name="txtVersion">
<property name="url">
<url>
<string>about:blank</string>
</url>
</property>
</widget>
</item>
Expand Down Expand Up @@ -294,6 +290,7 @@ p, li { white-space: pre-wrap; }
</tabstops>
<resources>
<include location="../../images/images.qrc"/>
<include location="../../images/images.qrc"/>
</resources>
<connections>
<connection>
Expand Down

0 comments on commit 7809cbd

Please sign in to comment.