Skip to content

Commit

Permalink
Use GDAL_DCAP_FEATURE_STYLES_READ/GDAL_DCAP_FEATURE_STYLES_WRITE on n…
Browse files Browse the repository at this point in the history
…ewer GDAL
  • Loading branch information
nyalldawson committed Dec 2, 2022
1 parent 9a39f24 commit 77dc2bd
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 0 deletions.
4 changes: 4 additions & 0 deletions src/core/providers/ogr/qgsogrprovider.cpp
Expand Up @@ -2848,8 +2848,12 @@ void QgsOgrProvider::computeCapabilities()
ability |= TransactionSupport;
}

#if GDAL_VERSION_NUM >= GDAL_COMPUTE_VERSION(3,7,0)
if ( GDALGetMetadataItem( mOgrLayer->driver(), GDAL_DCAP_FEATURE_STYLES_READ, nullptr ) != nullptr )
#else
// GDAL KML driver doesn't support reading feature style, skip metadata check until GDAL can separate reading/writing capability
if ( mGDALDriverName != QLatin1String( "KML" ) && GDALGetMetadataItem( mOgrLayer->driver(), GDAL_DCAP_FEATURE_STYLES, nullptr ) != nullptr )
#endif
{
ability |= FeatureSymbology;
ability |= CreateRenderer;
Expand Down
4 changes: 4 additions & 0 deletions src/core/qgsvectorfilewriter.cpp
Expand Up @@ -164,7 +164,11 @@ bool QgsVectorFileWriter::supportsFeatureStyles( const QString &driverName )
if ( !driverMetadata )
return false;

#if GDAL_VERSION_NUM >= GDAL_COMPUTE_VERSION(3,7,0)
return CSLFetchBoolean( driverMetadata, GDAL_DCAP_FEATURE_STYLES_WRITE, false );
#else
return CSLFetchBoolean( driverMetadata, GDAL_DCAP_FEATURE_STYLES, false );
#endif
}

void QgsVectorFileWriter::init( QString vectorFileName,
Expand Down

0 comments on commit 77dc2bd

Please sign in to comment.