Fix warnings

qgis · May 27, 2019 · 76d9a26 · 76d9a26
1 parent 9167cb4
commit 76d9a26
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/src/core/fieldformatter/qgsvaluerelationfieldformatter.cpp b/src/core/fieldformatter/qgsvaluerelationfieldformatter.cpp
@@ -201,7 +201,7 @@ QStringList QgsValueRelationFieldFormatter::valueToStringList( const QVariant &v
           }
         }
       }
-      catch ( json::parse_error ex )
+      catch ( json::parse_error &ex )
       {
         qDebug() << QString::fromStdString( ex.what() );
       }
@@ -210,6 +210,7 @@ QStringList QgsValueRelationFieldFormatter::valueToStringList( const QVariant &v
   else if ( value.type() == QVariant::List )
   {
     QVariantList valuesList( value.toList( ) );
+    checkList.reserve( valuesList.size() );
     for ( const QVariant &listItem : qgis::as_const( valuesList ) )
     {
       QString v( listItem.toString( ) );

diff --git a/src/core/qgsjsonutils.cpp b/src/core/qgsjsonutils.cpp
@@ -373,7 +373,7 @@ QVariantList QgsJsonUtils::parseArray( const QString &json, QVariant::Type type
       }
     }
   }
-  catch ( json::parse_error ex )
+  catch ( json::parse_error &ex )
   {
     errorMessage = ex.what();
     QgsLogger::warning( QStringLiteral( "Cannot parse json (%1): %2" ).arg( ex.what(), json ) );

diff --git a/src/providers/spatialite/qgsspatialiteprovider.cpp b/src/providers/spatialite/qgsspatialiteprovider.cpp
@@ -4418,7 +4418,7 @@ bool QgsSpatiaLiteProvider::changeAttributeValues( const QgsChangedAttributesMap
             jRepr = QString::fromStdString( jObj.dump( ) );
             sql += QStringLiteral( "%1=%2" ).arg( QgsSqliteUtils::quotedIdentifier( fld.name() ),  QgsSqliteUtils::quotedString( jRepr ) );
           }
-          catch ( json::exception ex )
+          catch ( json::exception &ex )
           {
             const auto errM { tr( "Field type is JSON but the value cannot be converted to JSON array: %1" ).arg( ex.what() ) };
             auto msgPtr { static_cast<char *>( sqlite3_malloc( errM.length() + 1 ) ) };