Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
osgeo4w: run nightly tests with separate temporary directories
  • Loading branch information
jef-n committed Jul 13, 2015
1 parent 2a7ccca commit 7634385
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions ms-windows/osgeo4w/package-nightly.cmd
Expand Up @@ -207,7 +207,13 @@ if exist ..\skiptests goto skiptests

echo RUN_TESTS: %DATE% %TIME%

set oldtemp=%TEMP%
set oldpath=%PATH%

set TEMP=%TEMP%\%PACKAGE%-%ARCH%
if exist %TEMP% rmdir /s /q %TEMP%
mkdir %TEMP%

for %%g IN (%GRASS_VERSIONS%) do (
set path=!path!;%OSGEO4W_ROOT%\apps\grass\grass-%%g\lib
set GISBASE=%OSGEO4W_ROOT%\apps\grass\grass-%%g
Expand All @@ -217,6 +223,7 @@ PATH %path%;%BUILDDIR%\output\plugins\%BUILDCONF%
cmake --build %BUILDDIR% --target Nightly --config %BUILDCONF%
if errorlevel 1 echo TESTS WERE NOT SUCCESSFUL.

set TEMP=%oldtemp%
PATH %oldpath%

:skiptests
Expand Down

3 comments on commit 7634385

@nyalldawson
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jef-n You're probably already aware of this, but this change has caused "Access Violation" errors in some of the unit tests for the nightlies. Eg, see http://dash.orfeo-toolbox.org/testDetails.php?test=31608774&build=191179

@jef-n
Copy link
Member Author

@jef-n jef-n commented on 7634385 Jul 17, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nyalldawson nope - it's the ogr connection pool. the global instance is destroyed before all references are destroyed - and unrefs then crash. Fixed in 4d681f0.

@nyalldawson
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jef-n ah, makes sense. Thanks for the with you've put into this!

Please sign in to comment.