Fix coverity ignored return value warnings

qgis · Dec 5, 2017 · 75c9980 · 75c9980
1 parent b0a36e9
commit 75c9980
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 9 deletions.
diff --git a/src/core/qgsfiledownloader.cpp b/src/core/qgsfiledownloader.cpp
@@ -174,10 +174,17 @@ void QgsFileDownloader::onFinished()
       QUrl newUrl = mUrl.resolved( redirectionTarget.toUrl() );
       mUrl = newUrl;
       mReply->deleteLater();
-      mFile.open( QIODevice::WriteOnly );
-      mFile.resize( 0 );
-      mFile.close();
-      startDownload();
+      if ( !mFile.open( QIODevice::WriteOnly ) )
+      {
+        mFile.remove();
+        error( tr( "Cannot open output file: %1" ).arg( mFile.fileName() ) );
+      }
+      else
+      {
+        mFile.resize( 0 );
+        mFile.close();
+        startDownload();
+      }
       return;
     }
     else

diff --git a/src/gui/attributetable/qgsattributetablemodel.cpp b/src/gui/attributetable/qgsattributetablemodel.cpp
@@ -289,9 +289,11 @@ void QgsAttributeTableModel::attributeValueChanged( QgsFeatureId fid, int idx, c
   {
     if ( mSortFieldIndex == -1 )
     {
-      loadFeatureAtId( fid );
-      mExpressionContext.setFeature( mFeat );
-      mSortCache[fid] = mSortCacheExpression.evaluate( &mExpressionContext );
+      if ( loadFeatureAtId( fid ) )
+      {
+        mExpressionContext.setFeature( mFeat );
+        mSortCache[fid] = mSortCacheExpression.evaluate( &mExpressionContext );
+      }
     }
     else
     {

diff --git a/src/providers/gdal/qgsgdalprovider.cpp b/src/providers/gdal/qgsgdalprovider.cpp
@@ -187,7 +187,7 @@ QgsGdalProvider::QgsGdalProvider( const QString &uri, bool update, GDALDatasetH
   }
   else
   {
-    initIfNeeded();
+    ( void )initIfNeeded();
   }
 }
 

diff --git a/tests/src/core/testqgsdxfexport.cpp b/tests/src/core/testqgsdxfexport.cpp
@@ -301,7 +301,7 @@ bool TestQgsDxfExport::fileContainsText( const QString &path, const QString &tex
 {
   QStringList searchLines = text.split( '\n' );
   QFile file( path );
-  file.open( QIODevice::ReadOnly );
+  QVERIFY( file.open( QIODevice::ReadOnly ) );
   QTextStream in( &file );
   QString line;
   do