Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Fix Coverity warnings in testqgsogcutils.cpp and testqgsgdalprovider.cpp
  • Loading branch information
rouault committed Jun 1, 2016
1 parent 2b1560c commit 73ab289
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 3 deletions.
3 changes: 2 additions & 1 deletion tests/src/core/testqgsogcutils.cpp
Expand Up @@ -432,7 +432,8 @@ void TestQgsOgcUtils::testExpressionToOgcFilterWFS11_data()
static QString normalizeXML( const QString& xmlText )
{
QDomDocument doc;
doc.setContent( xmlText, true );
if ( !doc.setContent( xmlText, true ) )
return QString();
return doc.toString( -1 );
}

Expand Down
10 changes: 8 additions & 2 deletions tests/src/providers/testqgsgdalprovider.cpp
Expand Up @@ -117,7 +117,10 @@ void TestQgsGdalProvider::noData()
QVERIFY( provider->isValid() );
QgsRasterDataProvider* rp = dynamic_cast< QgsRasterDataProvider* >( provider );
QVERIFY( rp );
QCOMPARE( rp->srcNoDataValue( 1 ), static_cast<double>( 255 ) );
if ( rp )
{
QCOMPARE( rp->srcNoDataValue( 1 ), static_cast<double>( 255 ) );
}
delete provider;
}

Expand All @@ -128,7 +131,10 @@ void TestQgsGdalProvider::invalidNoDataInSourceIgnored()
QVERIFY( provider->isValid() );
QgsRasterDataProvider* rp = dynamic_cast< QgsRasterDataProvider* >( provider );
QVERIFY( rp );
QCOMPARE( rp->srcHasNoDataValue( 1 ), false );
if ( rp )
{
QCOMPARE( rp->srcHasNoDataValue( 1 ), false );
}
delete provider;
}

Expand Down

0 comments on commit 73ab289

Please sign in to comment.